Merge lp://qastaging/~raoul-snyman/openlp/fix-wait-for-threads-error into lp://qastaging/openlp

Proposed by Raoul Snyman
Status: Merged
Merged at revision: 2900
Proposed branch: lp://qastaging/~raoul-snyman/openlp/fix-wait-for-threads-error
Merge into: lp://qastaging/openlp
Diff against target: 42 lines (+9/-1)
2 files modified
openlp/core/display/window.py (+2/-0)
openlp/core/ui/mainwindow.py (+7/-1)
To merge this branch: bzr merge lp://qastaging/~raoul-snyman/openlp/fix-wait-for-threads-error
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Review via email: mp+372669@code.qastaging.launchpad.net

Commit message

Minor cosmetic fixes to remove the "<2>" from the app title in KDE:
- Name the display window "Display Window"
- Name the threads dialog "Please Wait"
- Also fix potential issue where threads remove themselves from the dictionary at shutdown and cause an error.

Description of the change

Minor cosmetic fixes to remove the "<2>" from the app title in KDE:
- Name the display window "Display Window"
- Name the threads dialog "Please Wait"
- Also fix potential issue where threads remove themselves from the dictionary at shutdown and cause an error.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

JavaScript tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

macOS tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.