Merge lp://qastaging/~raoul-snyman/openlp/mac-niggles into lp://qastaging/openlp

Proposed by Raoul Snyman
Status: Merged
Merged at revision: 2711
Proposed branch: lp://qastaging/~raoul-snyman/openlp/mac-niggles
Merge into: lp://qastaging/openlp
Diff against target: 272 lines (+95/-22)
6 files modified
openlp/core/__init__.py (+17/-5)
openlp/core/common/settings.py (+3/-3)
openlp/core/ui/mainwindow.py (+8/-11)
openlp/core/ui/themewizard.py (+1/-1)
tests/functional/openlp_core_ui/test_shortcutlistdialog.py (+60/-0)
tests/functional/test_init.py (+6/-2)
To merge this branch: bzr merge lp://qastaging/~raoul-snyman/openlp/mac-niggles
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Review via email: mp+313403@code.qastaging.launchpad.net

Description of the change

Fix segfault on click on a spinner on macOS
Fix spurious traceback on some platforms or configurations of media players
Make the tab style affect only the media library tabs, not everything else too
Hide the splash screen when the backup dialog shows and when the exception form shows

Add this to your merge proposal:
--------------------------------
lp:~raoul-snyman/openlp/mac-niggles (revision 2713)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1873/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1784/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1723/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Windows_Functional_Tests/1462/
[SUCCESS] https://ci.openlp.io/job/Branch-04b-Windows_Interface_Tests/1052/
[SUCCESS] https://ci.openlp.io/job/Branch-05a-Code_Analysis/1120/
[SUCCESS] https://ci.openlp.io/job/Branch-05b-Test_Coverage/988/
[SUCCESS] https://ci.openlp.io/job/Branch-05c-Code_Analysis2/139/

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.