Merge lp://qastaging/~raoul-snyman/openlp/pymysql into lp://qastaging/openlp

Proposed by Raoul Snyman
Status: Merged
Merged at revision: 2895
Proposed branch: lp://qastaging/~raoul-snyman/openlp/pymysql
Merge into: lp://qastaging/openlp
Diff against target: 38 lines (+3/-3)
3 files modified
openlp/core/lib/db.py (+1/-1)
scripts/check_dependencies.py (+1/-1)
setup.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~raoul-snyman/openlp/pymysql
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Review via email: mp+371851@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-08-26.

Commit message

Change MySQL-Connector optional dependency to pymysql, a pure-Python MySQL client.

Description of the change

Change MySQL-Connector optional dependency to pymysql, a pure-Python MySQL client.

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

JavaScript tests failed, please see https://ci.openlp.io/job/MP-02-JavaScript-Tests/6/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

JavaScript tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

macOS tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Revision history for this message
Tim Bentley (trb143) wrote :

Approved

Revision history for this message
Tim Bentley (trb143) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.