OpenLP

Merge lp://qastaging/~raoul-snyman/openlp/pyro-impress into lp://qastaging/openlp

  1. pyro-impress
  2. Merge into trunk
Proposed by Raoul Snyman
Status: Superseded
Proposed branch: lp://qastaging/~raoul-snyman/openlp/pyro-impress
Merge into: lp://qastaging/openlp
Diff against target: 2439 lines (+2223/-56)
14 files modified
.bzrignore (+29/-38)
openlp/core/common/path.py (+2/-0)
openlp/core/ui/media/mediacontroller.py (+2/-0)
openlp/plugins/presentations/lib/libreofficeserver.py (+431/-0)
openlp/plugins/presentations/lib/maclocontroller.py (+266/-0)
openlp/plugins/presentations/lib/presentationcontroller.py (+3/-1)
openlp/plugins/presentations/lib/presentationtab.py (+2/-2)
openlp/plugins/presentations/lib/serializers.py (+52/-0)
openlp/plugins/presentations/lib/vendor/do_not_delete.txt (+5/-0)
openlp/plugins/presentations/presentationplugin.py (+16/-14)
scripts/check_dependencies.py (+2/-0)
tests/functional/openlp_core/common/test_path.py (+12/-1)
tests/functional/openlp_plugins/presentations/test_libreofficeserver.py (+948/-0)
tests/functional/openlp_plugins/presentations/test_maclocontroller.py (+453/-0)
To merge this branch: bzr merge lp://qastaging/~raoul-snyman/openlp/pyro-impress
Reviewer Review Type Date Requested Status
Tomas Groth Needs Fixing
Tim Bentley Pending
Review via email: mp+367787@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-05-18.

This proposal has been superseded by a proposal from 2019-06-05.

Description of the change

Add presentations through LibreOffice on macOS. Comments and criticisms welcome.

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote : Posted in a previous version of this proposal

Looks fine and does not show up on my machine (Linux).
Needs a respin as will have a conflict with previous merge.

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/55/ for more details

Revision history for this message
Tim Bentley (trb143) wrote : Posted in a previous version of this proposal

As commented all the license years are 2016 but that can be fixed with the gpl3 move!

review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

This is still a WIP branch. There are some changes that need to be made after merging with trunk.

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/156/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests failed, please see https://ci.openlp.io/job/MP-02-Linux_Tests/157/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

macOS tests passed!

Revision history for this message
Tomas Groth (tomasgroth) wrote :

Headers needs update - see inline.
I tried to test but the MacBook at hand was simply to slow to be of value....

review: Needs Fixing
lp://qastaging/~raoul-snyman/openlp/pyro-impress updated
2733. By Raoul Snyman

HEAD

2734. By Raoul Snyman

Fix license issues

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.