OpenLP

Merge lp://qastaging/~raoul-snyman/openlp/update-about into lp://qastaging/openlp

  1. update-about
  2. Merge into trunk
Proposed by Raoul Snyman
Status: Superseded
Proposed branch: lp://qastaging/~raoul-snyman/openlp/update-about
Merge into: lp://qastaging/openlp
Diff against target: 1405 lines (+675/-635)
3 files modified
openlp/core/ui/aboutdialog.py (+660/-621)
openlp/core/ui/aboutform.py (+8/-7)
tests/functional/openlp_core/ui/test_aboutform.py (+7/-7)
To merge this branch: bzr merge lp://qastaging/~raoul-snyman/openlp/update-about
Reviewer Review Type Date Requested Status
Tomas Groth Pending
Review via email: mp+371882@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-08-23.

This proposal has been superseded by a proposal from 2019-08-27.

Commit message

Update the About dialog:

- Changed the license to GPL3
- Removed a lot of old contributors
- Simplified credit tab content
- Linked to all the dependent libraries

Description of the change

Update the About dialog:

- Changed the license to GPL3
- Removed a lot of old contributors
- Simplified credit tab content
- Linked to all the dependent libraries

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Preview of the dialog:

https://cloud.snyman.info/index.php/apps/gallery/s/RETCYmSQZ7pA2ct

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

JavaScript tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

JavaScript tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

JavaScript tests failed, please see https://ci.openlp.io/job/MP-02-JavaScript-Tests/3/ for more details

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Linting passed!

Revision history for this message
Tomas Groth (tomasgroth) wrote : Posted in a previous version of this proposal

Since we on windows and Mac actually bundle the software we give credit to, I think we need to include which license each dependency has. Maybe like this: Qt5 (LGPL3). The license should then be a link to the license text.

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Sure, can do.

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

JavaScript tests passed!

Revision history for this message
Tim Bentley (trb143) wrote :

Approved

lp://qastaging/~raoul-snyman/openlp/update-about updated
2894. By Raoul Snyman

HEAD

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.