OpenLP

Merge lp://qastaging/~raoul-snyman/openlp/wix-packaging into lp://qastaging/openlp/packaging

  1. wix-packaging
  2. Merge into packaging
Proposed by Raoul Snyman
Status: Merged
Approved by: Raoul Snyman
Approved revision: 90
Merged at revision: 45
Proposed branch: lp://qastaging/~raoul-snyman/openlp/wix-packaging
Merge into: lp://qastaging/openlp/packaging
Diff against target: 2841 lines (+1001/-892)
11 files modified
builders/builder.py (+8/-4)
builders/windows-builder.py (+154/-61)
osx/Info.plist (+22/-2)
osx/LICENSE.txt (+624/-289)
pyinstaller-hooks/hook-sqlalchemy.ext.baked.py (+23/-0)
windows/LICENSE.txt (+0/-339)
windows/OpenLP-base.wxs (+152/-0)
windows/OpenLP.iss.default (+0/-187)
windows/config-appveyor.ini (+3/-4)
windows/config.ini.default (+5/-6)
windows/file-associations.xml (+10/-0)
To merge this branch: bzr merge lp://qastaging/~raoul-snyman/openlp/wix-packaging
Reviewer Review Type Date Requested Status
Tomas Groth Approve
Tim Bentley Pending
Review via email: mp+367668@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2019-05-07.

Commit message

Build a Windows Installer (MSI) file instead of using InnoSetup

Description of the change

Build a Windows Installer (MSI) file instead of using InnoSetup

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Tomas Groth (tomasgroth) wrote : Posted in a previous version of this proposal

The license file should be removed, but otherwise it looks fine. Haven't actually tested it...

review: Needs Fixing
Revision history for this message
Tomas Groth (tomasgroth) wrote : Posted in a previous version of this proposal

Add support for registrering "capabilities" (file extensions), as described here: https://stackoverflow.com/questions/2772452/how-to-associate-application-with-existing-file-types-using-wix-installer

review: Needs Fixing
Revision history for this message
Tomas Groth (tomasgroth) wrote : Posted in a previous version of this proposal

See inline

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Replies inline :-)

Revision history for this message
Bastian Germann (bastian-germann-deactivatedaccount) wrote : Posted in a previous version of this proposal

You can now use PyMuPDF instead of mupdf.exe

Revision history for this message
Tomas Groth (tomasgroth) wrote : Posted in a previous version of this proposal

See inline

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Please see my inline comment.

Revision history for this message
Tomas Groth (tomasgroth) wrote :

New inline comment..

review: Needs Fixing
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Replied :-)

Revision history for this message
Tomas Groth (tomasgroth) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches