Merge lp://qastaging/~rbalint/update-manager/do-release-upgrade-without-pkexec into lp://qastaging/update-manager

Proposed by Balint Reczey
Status: Merged
Merged at revision: 2802
Proposed branch: lp://qastaging/~rbalint/update-manager/do-release-upgrade-without-pkexec
Merge into: lp://qastaging/update-manager
Diff against target: 82 lines (+12/-8)
4 files modified
UpdateManager/Dialogs.py (+1/-6)
debian/changelog (+9/-0)
debian/control (+1/-1)
tests/test_upgrade.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~rbalint/update-manager/do-release-upgrade-without-pkexec
Reviewer Review Type Date Requested Status
Brian Murray Approve
Ubuntu Core Development Team Pending
Review via email: mp+337470@code.qastaging.launchpad.net
To post a comment you must log in.
2804. By Balint Reczey

Mention LP: #1748509 in the changelog

Revision history for this message
Brian Murray (brian-murray) wrote :

I tested this on my system which is encountering a crash when trying a partial upgrade and now I have a different traceback:

Traceback (most recent call last):
  File "/usr/lib/ubuntu-release-upgrader/do-partial-upgrade", line 93, in <module>
    logdir = setup_logging(options, config)
  File "/usr/lib/python3/dist-packages/DistUpgrade/DistUpgradeMain.py", line 98, in setup_logging
    with open(fname, "a"):
PermissionError: [Errno 13] Permission denied: '/var/log/dist-upgrade/main.log.partial'

2805. By Balint Reczey

Depend on ubuntu-release-upgrader-core shipping do-partial-upgrade which raises privileges properly

Revision history for this message
Balint Reczey (rbalint) wrote :

Thanks, I added the fix for u-r-u, too, please test them together.

Revision history for this message
Brian Murray (brian-murray) wrote :

I've tested them together and commented on an issue with u-r-u change, however once I fixed the u-r-u issue this worked fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: