Software Updater

Merge lp://qastaging/~rbalint/update-manager/retry-after-failed-transaction into lp://qastaging/update-manager

retry-after-failed-transaction
Merge into main

Proposed by Balint Reczey on 2018-09-10

Status:

Merged

Merged at revision:

2836

Proposed branch:

lp://qastaging/~rbalint/update-manager/retry-after-failed-transaction

Merge into:

lp://qastaging/update-manager

Diff against target:

159 lines (+50/-14)

5 files modified

UpdateManager/Core/MyCache.py (+2/-0)
UpdateManager/UpdateManager.py (+2/-2)
UpdateManager/backend/InstallBackendAptdaemon.py (+9/-1)
UpdateManager/backend/__init__.py (+23/-11)
debian/changelog (+14/-0)

To merge this branch:

bzr merge lp://qastaging/~rbalint/update-manager/retry-after-failed-transaction

Related bugs:

Bug #1317164: Show reason of TransactionFailed and let the user try again instead of crashing	High	Fix Released
Bug #1791931: Update-manager crashes in _show_transaction due to packages being already removed	High	Fix Released

Link a bug report

Reviewer	Date Requested	Status
Julian Andres Klode	2018-09-10	Approve on 2018-09-11
Brian Murray	2018-09-10	Pending
Review via email: mp+354648@code.qastaging.launchpad.net

Revision history for this message

Balint Reczey (rbalint) wrote on 2018-09-10:

Since update-manager does not hold a lock unattended-upgrades can change installed packages behind its back and u-m gets a failed transaction due to holding an outdated cache.
The user is now notified about the problem and can try again.

Revision history for this message

Julian Andres Klode (juliank) wrote on 2018-09-11:

bug 1702083 is

File "/usr/lib/python3/dist-packages/UpdateManager/Core/UpdateList.py", line 471, in update
self.distUpgradeWouldDelete = cache.saveDistUpgrade()
AttributeError: 'NoneType' object has no attribute 'saveDistUpgrade'

I don't see how that's relevant here.

Revision history for this message

Balint Reczey (rbalint) wrote on 2018-09-11:

> bug 1702083 is
>
> File "/usr/lib/python3/dist-packages/UpdateManager/Core/UpdateList.py", line
> 471, in update
> self.distUpgradeWouldDelete = cache.saveDistUpgrade()
> AttributeError: 'NoneType' object has no attribute 'saveDistUpgrade'
>
> I don't see how that's relevant here.

Ah, yes, sorry, fixed to LP: #1791931

Revision history for this message

Julian Andres Klode (juliank) wrote on 2018-09-11:

Needs some fixing

review: Needs Fixing

lp://qastaging/~rbalint/update-manager/retry-after-failed-transaction updated on 2018-09-11

2837. By Balint Reczey on 2018-09-11

Don't ask backend to do package operations aready done

Aptdaemon cancels the transaction when asked to remove packages already
removed which results the failure being shown to the user. This
is unnecessary as update-manager can just filter the package operations to
be done using a fresh cache and decrease the likelyhood of hitting
a race condition where packages to be removed are already removed.

LP: #1791931

2838. By Balint Reczey on 2018-09-11