simplestreams

Merge lp://qastaging/~rcj/simplestreams/lxd into lp://qastaging/simplestreams

  1. lxd
  2. Merge into trunk
Proposed by Robert C Jennings
Status: Merged
Merged at revision: 437
Proposed branch: lp://qastaging/~rcj/simplestreams/lxd
Merge into: lp://qastaging/simplestreams
Diff against target: 96 lines (+43/-22)
2 files modified
tools/make-test-data (+41/-21)
tools/toolutil.py (+2/-1)
To merge this branch: bzr merge lp://qastaging/~rcj/simplestreams/lxd
Reviewer Review Type Date Requested Status
Dan Watkins (community) Approve
simplestreams-dev Pending
Review via email: mp+297798@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Dan Watkins (oddbloke) wrote :

Overall approach looks good; comments inline.

review: Needs Fixing
Revision history for this message
Dan Watkins (oddbloke) wrote :

Looks much better; one remaining question.

review: Needs Information
Revision history for this message
Robert C Jennings (rcj) wrote :

fixed.

Revision history for this message
Dan Watkins (oddbloke) wrote :

SHIP IT

review: Approve
lp://qastaging/~rcj/simplestreams/lxd updated
437. By Robert C Jennings

Create chksum for LXD metadata+root for squashfs (LP: #1577922)

This adds a 'combined_sqashfs_sha256' element to items that have
both a LXD metadata tar and a squashfs root. Additionally, we
have 'combined_rootxz_sha256' which wil have the same value as
'combined_sha256' and allow for sunsetting that ambiguous name.

Revision history for this message
Robert C Jennings (rcj) wrote :

I combined the revisions for a clean upstream merge with a good commit message. No code changes. Merging now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches