lp://qastaging/libchromeos

Created by Ted Gould and last modified
Get this branch:
bzr branch lp://qastaging/libchromeos

Related bugs

Related blueprints

Branch information

Owner:
Registry Administrators
Project:
libchromeos
Status:
Development

Import details

Import Status: Suspended

This branch is an import of the HEAD branch of the Git repository at http://git.chromium.org/chromiumos/platform/libchromeos.git.

Last successful import was .

Import started on russkaya and finished taking 25 seconds — see the log
Import started on pear and finished taking 15 seconds — see the log
Import started on pear and finished taking 15 seconds — see the log
Import started on russkaya and finished taking 25 seconds — see the log

Recent revisions

166. By Yunlian Jiang <email address hidden>

libchromes: remove '-Wl,-z,defs' when asan enabled.

This removes the '-Wl,-z,defs' from link command line when
asan is enabled to make the asan build pass.
This is the same issue as
https://code.google.com/p/address-sanitizer/issues/detail?id=111
BUG=None
TEST=libchromes build successfully with asan.
Change-Id: Ic59a0e115fa5d9751ba7ff3e71b1fb93b0e25912
Reviewed-on: https://gerrit.chromium.org/gerrit/65737
Reviewed-by: Mike Frysinger <email address hidden>
Tested-by: Yunlian Jiang <email address hidden>
Commit-Queue: Yunlian Jiang <email address hidden>

165. By Liam McLoughlin <email address hidden>

Add libchromeos/libpolicy GYP file

BUG=chromium:220003
TEST=Run emerge-<board> -v platform2 with and without platform2 USE
flag on a range of boards plus the host

Change-Id: I65a1fc8738070f7d8aa9b47e146b3f5860a0c7fd
Reviewed-on: https://gerrit.chromium.org/gerrit/38286
Reviewed-by: Mike Frysinger <email address hidden>
Commit-Queue: Liam McLoughlin <email address hidden>
Tested-by: Liam McLoughlin <email address hidden>

164. By Mike Frysinger <email address hidden>

ProcessImpl: fix uid/gid checks

The code sets the initial uid/gid to -1 and then does uid_t>=0 to see if
the caller has initialized things. The issue is that uid_t/gid_t are not
signed, so the >=0 check always returns true.

Instead, check against the explicit default value (-1) so that gcc will
cast them up to the same values.

Building the code warned us about this too:
chromeos/process.cc:188:14: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
    if (gid_ >= 0 && setresgid(gid_, gid_, gid_) < 0) {
        ~~~~ ^ ~
chromeos/process.cc:193:14: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
    if (uid_ >= 0 && setresuid(uid_, uid_, uid_) < 0) {
        ~~~~ ^ ~

BUG=None
TEST=`cros_run_unit_tests --board=x86-alex -p libchromeos` passes

Change-Id: I8b90744b289e0fe3131aec0451222070aa9c592f
Reviewed-on: https://gerrit.chromium.org/gerrit/56113
Reviewed-by: Elly Jones <email address hidden>
Commit-Queue: Mike Frysinger <email address hidden>
Tested-by: Mike Frysinger <email address hidden>

163. By Mike Frysinger <email address hidden>

cryptohome: add GetHashedUserPath() helper

When you already have a hashed copy of the username, we don't want to
use GetUserPath() as that will hash the username a second time. Add
a helper where we can pash in the hashed value and bypass things.

BUG=chromium:221778
TEST=`cros_run_unit_tests --board=x86-alex -p libchromeos` passes

Change-Id: I16a04ff1e9cf145eb974438a5e0477d8b30e3c4b
Reviewed-on: https://gerrit.chromium.org/gerrit/56112
Reviewed-by: Elly Jones <email address hidden>
Commit-Queue: Mike Frysinger <email address hidden>
Tested-by: Mike Frysinger <email address hidden>

162. By Jay Srinivasan <email address hidden>

Expose newly added HTTP-based downloads AU policy via libchromeos

BUG=chromium:235562
TEST=Unit tests pass.

Change-Id: I5c03ae887de549fa385b7f994299df645598c781
Reviewed-on: https://gerrit.chromium.org/gerrit/51235
Reviewed-by: Chris Sosa <email address hidden>
Commit-Queue: Jay Srinivasan <email address hidden>
Tested-by: Jay Srinivasan <email address hidden>

161. By Elly Fong-Jones <email address hidden>

[libchromeos] grab current cryptohome Platform

cryptohome currently has the most 'complete' Platform, so fault it into here,
then we'll have cryptohome use it. The ecryptfs/keyutils wrappers are stubs that
explode when called to avoid forcing every use of libchromeos to link
libkeyutils and libecryptfs.

TEST=unit,trybot
BUG=chromium:216672

Change-Id: I3121aac23df740fd65eea6d23b70c1939c2d8290
Signed-off-by: Elly Fong-Jones <email address hidden>
Reviewed-on: https://gerrit.chromium.org/gerrit/50172
Reviewed-by: Will Drewry <email address hidden>

160. By Chris Masone <email address hidden>

Add new session_manager errors appropriate for multiprofile

CHROMEOS_LOGIN_ERROR_POLICY_INIT_FAIL, for when we can't create a
UserPolicyService for a new user.

BUG=chromium:235179
TEST=emerge-amd64-generic libchromeos, check for new constants in installed headers.

Change-Id: If95842ef3866dcc208b1a09d226684817e648873
Reviewed-on: https://gerrit.chromium.org/gerrit/49601
Tested-by: Chris Masone <email address hidden>
Reviewed-by: Mattias Nissler <email address hidden>
Commit-Queue: Chris Masone <email address hidden>

159. By Chris Masone <email address hidden>

Coerce username to lowercase before sanitzing.

Coercing the username to lowercase before sanitzing ensures that,
no matter what CaPitaliZation the caller uses, the same value
is returned.

BUG=None
TEST=unit tests
TEST=lumpy trybot run.

Change-Id: Id9c68031cc5ac9588847a81f4a68c91a74b8bc26
Reviewed-on: https://gerrit.chromium.org/gerrit/49731
Tested-by: Chris Masone <email address hidden>
Reviewed-by: Will Drewry <email address hidden>
Commit-Queue: Chris Masone <email address hidden>

158. By Chris Masone <email address hidden>

Change GetGuestUserName() to kGuestUserName

Having a method that takes a string literal and returns a copy as
a std::string seems odd. We can keep this as a kOnstant,
and reduce copies while also remaining more flexible.

CQ-DEPEND=I5aee09cb66e60ef3b5f8f64bf76d7dd7837dab41

BUG=None
TEST=build libchromeos

Change-Id: Ie070102429856f21e571cc1073e661d6b5b1c5f3
Reviewed-on: https://gerrit.chromium.org/gerrit/49605
Tested-by: Chris Masone <email address hidden>
Reviewed-by: Will Drewry <email address hidden>
Commit-Queue: Chris Masone <email address hidden>

157. By Elly Fong-Jones <email address hidden>

[libchromeos] add GetGuestUserName

BUG=chromium:224288
TEST=adhoc
Patch in https://gerrit.chromium.org/gerrit/#/c/47262/ then run cryptohome unit
tests

Change-Id: I5503ec33f5b235e48cc5c78400e2c6d74227e9f1
Signed-off-by: Elly Fong-Jones <email address hidden>
Reviewed-on: https://gerrit.chromium.org/gerrit/47637
Reviewed-by: Will Drewry <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.