Merge lp://qastaging/~renatofilho/address-book-app/avoid-edit-readonly-contacts into lp://qastaging/address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 530
Merged at revision: 525
Proposed branch: lp://qastaging/~renatofilho/address-book-app/avoid-edit-readonly-contacts
Merge into: lp://qastaging/address-book-app
Diff against target: 64 lines (+18/-7)
3 files modified
src/app/addressbookapp.cpp (+14/-4)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailSyncTargetEditor.qml (+3/-2)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/avoid-edit-readonly-contacts
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+280961@code.qastaging.launchpad.net

Commit message

Block edit read-only contacts.
Does not allow select read-only sources while creating a new contact;

To post a comment you must log in.
528. By Renato Araujo Oliveira Filho

Remove debug messages.

529. By Renato Araujo Oliveira Filho

Revert unnecessary changes.

530. By Renato Araujo Oliveira Filho

Add comments.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches