address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/choose-default-address-book into lp://qastaging/address-book-app

choose-default-address-book
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2015-12-01

Status:

Merged

Approved by:

Bill Filler on 2015-12-14

Approved revision:

502

Merged at revision:

520

Proposed branch:

lp://qastaging/~renatofilho/address-book-app/choose-default-address-book

Merge into:

lp://qastaging/address-book-app

Diff against target:

529 lines (+330/-46)

8 files modified

src/app/addressbookapp.cpp (+1/-0)
src/app/addressbookapp.h (+1/-0)
src/imports/ABContactEditorPage.qml (+4/-0)
src/imports/Settings/CMakeLists.txt (+1/-0)
src/imports/Settings/SettingsDefaultSyncTarget.qml (+229/-0)
src/imports/Settings/SettingsPage.qml (+10/-0)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailSyncTargetEditor.qml (+81/-40)
tests/qml/tst_ContactEditor.qml (+3/-6)

To merge this branch:

bzr merge lp://qastaging/~renatofilho/address-book-app/choose-default-address-book

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-12-11
Bill Filler (community)			Needs Fixing on 2015-12-07
Gustavo Pichorim Boiko (community)		2015-12-01	Approve on 2015-12-03
Review via email: mp+279135@code.qastaging.launchpad.net

Commit message

Implemented the ability to choose the default address-book from settings page.

Description of the change

TESTING
========

* Test change the default address-book:
  * Open address-book app
  * Enter on settings page
  * Select a different "Default address book"
  * Close settings page
  * Do a bottom edge swipe to create a new contact
  * Check if the selected address-book is the one that you choose on settings page.
  * Save the contact
  * Open the recent created contact and check if the address-book is the correct one

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-01:

FAILED: Continuous integration, rev:496
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1038/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/341
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5530
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4331
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5544
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5544/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25673

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1038/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2015-12-02:

Just a couple remarks.

review: Needs Fixing

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-12-03:

All comments fixed on rev.497

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2015-12-03:

Looks good now!

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-03:

FAILED: Continuous integration, rev:497
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1045/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/348
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5574
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4366
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5588
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5588/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25776

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1045/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2015-12-07:

If I switch off contact syncing for any account in the list, it should be removed from the list. If the account was the default account, then Personal should be made the new default account.

review: Needs Fixing

Revision history for this message

Bill Filler (bfiller) wrote on 2015-12-07:

If I switch contact-sync back on for the account then it should be added back to the list, but not made the default

review: Needs Fixing

lp://qastaging/~renatofilho/address-book-app/choose-default-address-book updated on 2015-12-07

498. By Renato Araujo Oliveira Filho on 2015-12-07: Update source list on application active to keep it in sync.
499. By Renato Araujo Oliveira Filho on 2015-12-07: Make sure the correct source is selected after reload source list.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-07:

FAILED: Continuous integration, rev:499
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1053/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/356
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5632
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4393
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5646
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5646/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25854

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1053/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/choose-default-address-book updated on 2015-12-11

500. By Renato Araujo Oliveira Filho on 2015-12-11: Trunk merged.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-11:

FAILED: Continuous integration, rev:500
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1065/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/368
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5730/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5743/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1065/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/choose-default-address-book updated on 2015-12-11

501. By Renato Araujo Oliveira Filho on 2015-12-11: Created 'saveActionEnabled' property to avoid problems on tests.
Used that new property instead of search for Action.