Merge lp://qastaging/~renatofilho/address-book-app/contact-view into lp://qastaging/address-book-app
Proposed by
Renato Araujo Oliveira Filho
| Status: | Merged |
|---|---|
| Approved by: | Gustavo Pichorim Boiko |
| Approved revision: | 15 |
| Merged at revision: | 4 |
| Proposed branch: | lp://qastaging/~renatofilho/address-book-app/contact-view |
| Merge into: | lp://qastaging/address-book-app |
| Diff against target: |
1483 lines (+930/-297) 21 files modified
src/artwork/CMakeLists.txt (+23/-6) src/imports/CMakeLists.txt (+2/-2) src/imports/ContactEditor.qml (+0/-113) src/imports/ContactList.js (+15/-5) src/imports/ContactList.qml (+59/-68) src/imports/ContactSettings.qml (+0/-98) src/imports/ContactView/CMakeLists.txt (+20/-0) src/imports/ContactView/ContactDetailAvatar.qml (+37/-0) src/imports/ContactView/ContactDetailEditor.qml (+23/-0) src/imports/ContactView/ContactDetailEditorText.qml (+32/-0) src/imports/ContactView/ContactDetailFavorite.qml (+36/-0) src/imports/ContactView/ContactDetailGroup.qml (+66/-0) src/imports/ContactView/ContactDetailItem.qml (+64/-0) src/imports/ContactView/ContactDetailName.qml (+63/-0) src/imports/ContactView/ContactDetailView.qml (+23/-0) src/imports/ContactView/ContactDetailViewText.qml (+32/-0) src/imports/ContactView/ContactDetailViewWithAction.qml (+107/-0) src/imports/ContactView/ContactEditor.qml (+143/-0) src/imports/ContactView/ContactHeader.qml (+71/-0) src/imports/ContactView/DetailTypeUtilities.js (+98/-0) src/imports/main.qml (+16/-5) |
| To merge this branch: | bzr merge lp://qastaging/~renatofilho/address-book-app/contact-view |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gustavo Pichorim Boiko (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Approve | |
| Bill Filler (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Implemented ContactView based on designer doc.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:7
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://