address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/create-contact-preview-page into lp://qastaging/~phablet-team/address-book-app/staging

  1. create-contact-preview-page
  2. Merge into staging
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Merge reported by: Renato Araujo Oliveira Filho
Merged at revision: not available
Proposed branch: lp://qastaging/~renatofilho/address-book-app/create-contact-preview-page
Merge into: lp://qastaging/~phablet-team/address-book-app/staging
Diff against target: 1544 lines (+621/-301)
41 files modified
src/imports/Common/CMakeLists.txt (+0/-3)
src/imports/Common/ContactDetailItem.qml (+2/-1)
src/imports/Common/RemoveContactsDialog.qml (+2/-2)
src/imports/ContactEdit/AddFieldDialog.qml (+4/-3)
src/imports/ContactEdit/AvatarImport.qml (+12/-11)
src/imports/ContactEdit/ContactDetailAddressesEditor.qml (+8/-8)
src/imports/ContactEdit/ContactDetailAvatarEditor.qml (+3/-3)
src/imports/ContactEdit/ContactDetailEmailsEditor.qml (+5/-4)
src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml (+6/-6)
src/imports/ContactEdit/ContactDetailNameEditor.qml (+5/-4)
src/imports/ContactEdit/ContactDetailOnlineAccountsEditor.qml (+4/-5)
src/imports/ContactEdit/ContactDetailOrganizationsEditor.qml (+5/-7)
src/imports/ContactEdit/ContactDetailPhoneNumbersEditor.qml (+4/-5)
src/imports/ContactEdit/ContactDetailSyncTargetEditor.qml (+4/-4)
src/imports/ContactEdit/ContactDetailWithTypeEditor.qml (+3/-4)
src/imports/ContactEdit/ContactEditor.qml (+7/-6)
src/imports/ContactView/CMakeLists.txt (+0/-13)
src/imports/ContactView/ContactDetailSyncTargetView.qml (+1/-0)
src/imports/ContactView/ContactView.qml (+11/-107)
src/imports/Ubuntu/Contacts/BasicFieldView.qml (+0/-2)
src/imports/Ubuntu/Contacts/CMakeLists.txt (+22/-6)
src/imports/Ubuntu/Contacts/ContactDetailAddressesView.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactDetailAvatarView.qml (+2/-5)
src/imports/Ubuntu/Contacts/ContactDetailBase.qml (+0/-1)
src/imports/Ubuntu/Contacts/ContactDetailGroupBase.qml (+0/-2)
src/imports/Ubuntu/Contacts/ContactDetailGroupWithTypeBase.qml (+0/-1)
src/imports/Ubuntu/Contacts/ContactDetailGroupWithTypeView.qml (+0/-2)
src/imports/Ubuntu/Contacts/ContactDetailOnlineAccountsView.qml (+0/-3)
src/imports/Ubuntu/Contacts/ContactDetailOrganizationsView.qml (+0/-3)
src/imports/Ubuntu/Contacts/ContactDetailPhoneNumberView.qml (+0/-4)
src/imports/Ubuntu/Contacts/ContactDetailPhoneNumbersView.qml (+0/-4)
src/imports/Ubuntu/Contacts/ContactDetailWithTypeView.qml (+0/-4)
src/imports/Ubuntu/Contacts/ContactPreviewPage.qml (+138/-0)
src/imports/Ubuntu/Contacts/DialogButtons.qml (+0/-62)
src/imports/Ubuntu/Contacts/VCardParser.qml (+57/-0)
src/imports/Ubuntu/Contacts/qmldir (+22/-5)
tests/data/CMakeLists.txt (+2/-0)
tests/data/vcard_single.vcf (+16/-0)
tests/qml/CMakeLists.txt (+4/-0)
tests/qml/tst_ContactPreviewPage.qml (+208/-0)
tests/qml/tst_VCardParser.qml (+63/-0)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/create-contact-preview-page
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Tiago Salem Herrmann (community) Approve
Review via email: mp+230709@code.qastaging.launchpad.net

Commit message

* Created ContactPreviewPage component and extend it to be used by other apps.
* Created VCardParser component.

Description of the change

HOW TO TEST
===========

- Check if all unittest run ok
- Check if the contact edit and contact view page still working good.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:240
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/282/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3507
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2761
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-amd64-ci/282
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-ci/282
        deb: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-ci/282/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/282
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3403
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4754
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4754/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11428
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2233
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3038
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3038/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/282/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good to me. works fine on the device too.
Thanks.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-autolanding/71/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3578/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2811
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-amd64-autolanding/71
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-autolanding/71
        deb: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-autolanding/71/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-autolanding/71
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4825/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2280
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3091
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3091/artifact/work/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches