address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items into lp://qastaging/address-book-app

empty-state-on-list-items
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2015-02-05

Status:

Merged

Approved by:

Bill Filler on 2015-02-12

Approved revision:

385

Merged at revision:

368

Proposed branch:

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items

Merge into:

lp://qastaging/address-book-app

Diff against target:

1423 lines (+495/-394)

17 files modified

debian/control (+5/-3)
po/address-book-app.pot (+28/-30)
src/app/addressbookapp.cpp (+0/-52)
src/app/addressbookapp.h (+0/-9)
src/imports/ContactList/CMakeLists.txt (+0/-2)
src/imports/ContactList/ContactListPage.qml (+28/-127)
src/imports/ContactList/OnlineAccountsMessage.qml (+0/-110)
src/imports/Ubuntu/Contacts/CMakeLists.txt (+3/-0)
src/imports/Ubuntu/Contacts/ContactListButtonDelegate.qml (+88/-0)
src/imports/Ubuntu/Contacts/ContactListView.qml (+133/-9)
src/imports/Ubuntu/Contacts/ContactSimpleListView.qml (+1/-1)
src/imports/Ubuntu/Contacts/OnlineAccountsDummy.qml (+28/-0)
src/imports/Ubuntu/Contacts/OnlineAccountsHelper.qml (+8/-12)
src/imports/Ubuntu/Contacts/qmldir (+1/-0)
tests/qml/CMakeLists.txt (+2/-0)
tests/qml/tst_ContactList.qml (+1/-39)
tests/qml/tst_ContactListView.qml (+169/-0)

To merge this branch:

bzr merge lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-02-10
Ubuntu Phablet Team		2015-02-05	Pending
Review via email: mp+248787@code.qastaging.launchpad.net

Commit message

Implement new empty state for contact list with support for contact import options.

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items updated on 2015-02-05

366. By Renato Araujo Oliveira Filho on 2015-02-05: show import options only with empty list.
367. By Renato Araujo Oliveira Filho on 2015-02-05: Fix contact list view layout.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-05:

PASSED: Continuous integration, rev:366
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/727/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1196
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/553
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1055
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1194
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1194/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17813
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/449
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/663
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/663/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/727/rebuild

review: Approve (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items updated on 2015-02-05

368. By Renato Araujo Oliveira Filho on 2015-02-05: Does not show import options if searching.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-05:

PASSED: Continuous integration, rev:367
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/728/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1198
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/554
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1059
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1196
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1196/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17820
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/452
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/664
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/664/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/728/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-06:

PASSED: Continuous integration, rev:368
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/730/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1205
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/558
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1064
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1203
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1203/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17827
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/456
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/668
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/668/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/730/rebuild

review: Approve (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items updated on 2015-02-06

369. By Renato Araujo Oliveira Filho on 2015-02-06: Create unit test for the addNew and importContacts buttons.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-06:

FAILED: Continuous integration, rev:369
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/732/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/35/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1214/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/565/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1212/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/675/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/732/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items updated on 2015-02-06

370. By Renato Araujo Oliveira Filho on 2015-02-06: Added qtdeclarative5-online-accounts-client0.1 as build dep.
371. By Renato Araujo Oliveira Filho on 2015-02-06: Added 'qtdeclarative5-accounts-plugin' as build dep.
372. By Renato Araujo Oliveira Filho on 2015-02-06: Run contact list view in dummy mode during tests, to avoid problems with online account plugin.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-06:

FAILED: Continuous integration, rev:371
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/733/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/36/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1220/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/567/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1218/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/677/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/733/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items updated on 2015-02-06

373. By Renato Araujo Oliveira Filho on 2015-02-06: Fixed impot buttons visibility while searching.
374. By Renato Araujo Oliveira Filho on 2015-02-06: Fixed buttom margins.
375. By Renato Araujo Oliveira Filho on 2015-02-06: Does not show import options in favorites list.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-06:

FAILED: Continuous integration, rev:372
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/734/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/37/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1227/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/570/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1225/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/680/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/734/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-07:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/735/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items updated on 2015-02-09

376. By Renato Araujo Oliveira Filho on 2015-02-09: Wait some msecs before show sync from google button if the list is empty.
Change the sync from google button to a spinner while loading online accounts page.
377. By Renato Araujo Oliveira Filho on 2015-02-09: Moved SyncMonitor functionalities to ContactList.
378. By Renato Araujo Oliveira Filho on 2015-02-09: Added missing build dep 'qtdeclarative5-ubuntu-syncmonitor0.1'

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-09:

FAILED: Continuous integration, rev:377
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/736/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/39/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1247/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/580/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1245/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/690/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/736/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items updated on 2015-02-09

379. By Renato Araujo Oliveira Filho on 2015-02-09: Updated unit test for the new contact list properties.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-09:

PASSED: Continuous integration, rev:379
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/737/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/40
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1252
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/582
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1250
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1250/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17889
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/474
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/692
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/692/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/737/rebuild

review: Approve (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items updated on 2015-02-09

380. By Renato Araujo Oliveira Filho on 2015-02-09: Add some delay to show "import from google" button. To avoid it to appear while loading contacts.
381. By Renato Araujo Oliveira Filho on 2015-02-09: Avoid to show the contact list page empty state if the list still loading.
382. By Renato Araujo Oliveira Filho on 2015-02-09: Updated pot file.

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-02-09:

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed UI labels, did you update the pot file? yes

If you changed the packaging, did you add a core-dev as a reviewer to this MP? yes

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-09:

PASSED: Continuous integration, rev:382
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/738/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/41
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1255
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/583
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1108
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1253
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1253/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17894
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/475
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/693
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/693/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/738/rebuild

review: Approve (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/empty-state-on-list-items updated on 2015-02-10

383. By Renato Araujo Oliveira Filho on 2015-02-10: Reduced the loading time.
384. By Renato Araujo Oliveira Filho on 2015-02-10: Trunk merged.
385. By Renato Araujo Oliveira Filho on 2015-02-10: Does not show the empty state screen on favorite page.