address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/fix-1367325 into lp://qastaging/~phablet-team/address-book-app/staging

  1. fix-1367325
  2. Merge into staging
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Arthur Mello
Approved revision: 299
Merged at revision: 300
Proposed branch: lp://qastaging/~renatofilho/address-book-app/fix-1367325
Merge into: lp://qastaging/~phablet-team/address-book-app/staging
Diff against target: 38 lines (+28/-0)
1 file modified
src/imports/ContactList/ContactListPage.qml (+28/-0)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/fix-1367325
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Arthur Mello (community) Approve
Review via email: mp+234863@code.qastaging.launchpad.net

Commit message

Implemented empty state message on contact list, based on messaging app.

Description of the change

HOW TO TEST
===========

Make sure that you contact list is empty.
1 - Open the address-book-app
2 - After the spinner run for a while the empty message should appear
3 - Create a new contact
4 - Go back to contact list, the list should show the contact and the "empty" message should disappear.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:299
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/330/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4869
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3560
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/330
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4625
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6121
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6121/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13277
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2949
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3867
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3867/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/330/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches