address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/fix-1371243 into lp://qastaging/~phablet-team/address-book-app/staging

  1. fix-1371243
  2. Merge into staging
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Michał Karnicki
Approved revision: 312
Merged at revision: 312
Proposed branch: lp://qastaging/~renatofilho/address-book-app/fix-1371243
Merge into: lp://qastaging/~phablet-team/address-book-app/staging
Diff against target: 189 lines (+39/-43)
4 files modified
src/imports/ContactList/ContactExporter.qml (+12/-8)
src/imports/ContactList/ContactListPage.qml (+24/-33)
src/imports/ContactShare/ContactSharePage.qml (+1/-1)
src/imports/ContentHubProxy.qml (+2/-1)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/fix-1371243
Reviewer Review Type Date Requested Status
Michał Karnicki (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+235708@code.qastaging.launchpad.net

Commit message

Fetch the full contact before export it on contact list.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:308
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/342/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5109/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3722
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/342
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4857/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6361
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6361/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13622
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3115
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4033
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4033/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/342/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~renatofilho/address-book-app/fix-1371243 updated
309. By Renato Araujo Oliveira Filho

Hide select all button if the list is in single selection mode.

Revision history for this message
Michał Karnicki (karni) wrote :

Left some in-line questions. Marking as "needs information" only because I have questions, since I'm not familiar with the code base.

review: Needs Information
lp://qastaging/~renatofilho/address-book-app/fix-1371243 updated
310. By Renato Araujo Oliveira Filho

Renamed ContactExporter signal name from contactFetched to contactsFetched

311. By Renato Araujo Oliveira Filho

Used contact name on vcard file used during the contact export process.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) :
Revision history for this message
Michał Karnicki (karni) wrote :

Lookds good to me. I would advise at least another review from the apps team.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:309
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/347/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5353
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3859
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/347
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5067
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6605
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6605/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13969
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3240
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4172
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4172/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/347/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:311
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/348/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5360
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3866
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/348
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5072
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6612
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6612/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13973
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3247
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4179
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4179/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/348/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Karnicki (karni) wrote :

Renato, I'm getting 404, can't test the deb.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:311
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/349/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5374
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3872
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/349
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5084
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6626
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6626/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13998
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3252
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4185
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4185/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/349/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/address-book-app/fix-1371243 updated
312. By Renato Araujo Oliveira Filho

Fixed content hub import in single mode.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:312
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/350/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5394
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3881
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/350
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5102
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6646
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6646/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14024
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3258
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4194
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4194/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/350/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Karnicki (karni) wrote :

Works fine, although I find it confusing to see checkboxes in a single select mode. Clicking on a contact should be, in my opinion, sufficient to pick it. The 'share' button seems artifical, but I can guess that has been 'designed that way'.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches