address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/fix-1387659 into lp://qastaging/address-book-app

  1. fix-1387659
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Superseded
Proposed branch: lp://qastaging/~renatofilho/address-book-app/fix-1387659
Merge into: lp://qastaging/address-book-app
Diff against target: 101 lines (+14/-5)
1 file modified
src/imports/ContactList/ContactListPage.qml (+14/-5)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/fix-1387659
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+241275@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2014-11-11.

Commit message

Show "No contacts." for empty list in pick mode.
Hide search button if the list is empty.
Make the "share" and "select" buttons invisible if the contact list is empty.
Used the new property "preset" to show header actions label when in selection mode.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:321
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/702/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/90
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/53
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/86
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/90
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/90/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15628
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/50
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/56
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/56/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/702/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/address-book-app/fix-1387659 updated
322. By Renato Araujo Oliveira Filho

Merged: lp:~renatofilho/address-book-app/fix-1390128

323. By Renato Araujo Oliveira Filho

Resync parent branch.

324. By Renato Araujo Oliveira Filho

Do not async load content hub object. Async load can cause some signal to get lost due the delay to create the component.

325. By Renato Araujo Oliveira Filho

Do not use preset property in the header.

326. By Renato Araujo Oliveira Filho

Use "You have no contacts." string instead of "no contacts".

This will avoid create a new string to be translated.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches