Merge lp://qastaging/~renatofilho/address-book-app/fix-1420851 into lp://qastaging/address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Needs review
Proposed branch: lp://qastaging/~renatofilho/address-book-app/fix-1420851
Merge into: lp://qastaging/address-book-app
Diff against target: 88 lines (+23/-6)
4 files modified
src/imports/Ubuntu/Contacts/BasicFieldView.qml (+1/-0)
src/imports/Ubuntu/Contacts/ContactDelegate.qml (+1/-0)
src/imports/Ubuntu/Contacts/ContactPreviewPage.qml (+18/-3)
tests/qml/tst_ContactPreviewPage.qml (+3/-3)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/fix-1420851
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+249380@code.qastaging.launchpad.net

Commit message

Used Text.PlainText format for all labels.

To post a comment you must log in.
370. By Renato Araujo Oliveira Filho

Used plain text format on contact delegate title.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
371. By Renato Araujo Oliveira Filho

Created a WORKAROUND for page title.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
372. By Renato Araujo Oliveira Filho

Create the pageTitle property on ContactPreviewPage to help on tests.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

372. By Renato Araujo Oliveira Filho

Create the pageTitle property on ContactPreviewPage to help on tests.

371. By Renato Araujo Oliveira Filho

Created a WORKAROUND for page title.

370. By Renato Araujo Oliveira Filho

Used plain text format on contact delegate title.

369. By Renato Araujo Oliveira Filho

Used Text.PlainText for all fields labels.

368. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches