address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/fix-most-called-crash into lp://qastaging/~phablet-team/address-book-app/staging

  1. fix-most-called-crash
  2. Merge into staging
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 294
Merged at revision: 294
Proposed branch: lp://qastaging/~renatofilho/address-book-app/fix-most-called-crash
Merge into: lp://qastaging/~phablet-team/address-book-app/staging
Diff against target: 53 lines (+21/-17)
1 file modified
src/imports/Ubuntu/Contacts/MostCalledModel.qml (+21/-17)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/fix-most-called-crash
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+233397@code.qastaging.launchpad.net

Commit message

Move HistoryModel away from MostCalledContactsModel scope to avoid problems during the destruction.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:294
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/316/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4475
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3329
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/316
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4249
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5727
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5727/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12681
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2736
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3626
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3626/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/316/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches