address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty into lp://qastaging/address-book-app

hide-favorite-if-empty
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2015-10-29

Status:

Approved

Approved by:

Gustavo Pichorim Boiko on 2015-12-18

Approved revision:

514

Proposed branch:

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty

Merge into:

lp://qastaging/address-book-app

Diff against target:

989 lines (+678/-78)

13 files modified

src/imports/ABContactEditorPage.qml (+0/-1)
src/imports/ABContactListPage.qml (+20/-1)
src/imports/Ubuntu/Contacts/CMakeLists.txt (+2/-0)
src/imports/Ubuntu/Contacts/ContactListView.qml (+11/-0)
src/imports/Ubuntu/Contacts/MostCalledList.qml (+5/-1)
src/imports/Ubuntu/Contacts/contactmap.cpp (+293/-0)
src/imports/Ubuntu/Contacts/contactmap.h (+96/-0)
src/imports/Ubuntu/Contacts/mostcalledproxymodel.cpp (+8/-69)
src/imports/Ubuntu/Contacts/mostcalledproxymodel.h (+0/-4)
src/imports/Ubuntu/Contacts/plugin.cpp (+2/-0)
tests/qml/CMakeLists.txt (+6/-0)
tests/qml/ContactUtil.js (+9/-2)
tests/qml/tst_ContactMap.qml (+226/-0)

To merge this branch:

bzr merge lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty

Medium

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
Gustavo Pichorim Boiko (community)		2015-10-29	Approve on 2015-12-18
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-12-16
Review via email: mp+276126@code.qastaging.launchpad.net

Commit message

Only show favorite sections if the list contains favorite contacts.

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-10-29

494. By Renato Araujo Oliveira Filho on 2015-10-29: Only show header section if there is favorite contacts.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-29:

FAILED: Continuous integration, rev:493
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/989/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/292
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4919/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4916/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/989/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-30:

FAILED: Continuous integration, rev:494
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/992/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/295
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4935/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3963/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4932
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4932/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24729

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/992/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-11-05

495. By Renato Araujo Oliveira Filho on 2015-11-05: Trunk merged.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-06:

FAILED: Continuous integration, rev:495
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/998/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/301
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5034
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/4043
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5031
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5031/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24957

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/998/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-11-06

496. By Renato Araujo Oliveira Filho on 2015-11-06: Implemented contacts map.
Used to map contacts in groups, necessary to show groups in the page header.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-07:

PASSED: Continuous integration, rev:496
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/999/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/302
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5065
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/4060
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5069
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5069/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24989

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/999/rebuild

review: Approve (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-12-10

497. By Renato Araujo Oliveira Filho on 2015-12-09: Update unit test to work with the new SDK API.
498. By Renato Araujo Oliveira Filho on 2015-12-10: Implemented unit test for ContactMap.
499. By Renato Araujo Oliveira Filho on 2015-12-10: Renamed ContactsMap to ContactMap.
[Header.sections] Reset selectedIndex to 0 if model changes, to avoid it to stay on 'Favorite' Section

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-10:

FAILED: Continuous integration, rev:499
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1057/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/360/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5689/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5702/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1057/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-12-10

500. By Renato Araujo Oliveira Filho on 2015-12-10: Notify hasFavorites changed only if it really changed.
501. By Renato Araujo Oliveira Filho on 2015-12-10: [ContactMap] Fetch contacts async.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-10:

FAILED: Continuous integration, rev:501
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1058/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/361/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5696/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5709/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1058/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-12-10

502. By Renato Araujo Oliveira Filho on 2015-12-10: [ContactMap] Fixed contact population.
503. By Renato Araujo Oliveira Filho on 2015-12-10: Trunk merged.
504. By Renato Araujo Oliveira Filho on 2015-12-10: Removed debug messages.
Fixed code style.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-10:

FAILED: Continuous integration, rev:503
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1059/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/362
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5698
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4424
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5711
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5711/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25936

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1059/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-10:

FAILED: Continuous integration, rev:504
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1060/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/363
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5704
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4430
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5717
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5717/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25944

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1060/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-12-10

505. By Renato Araujo Oliveira Filho on 2015-12-10

Full load contacts before populate contact map.

This is necessary to avoid problems if the contact map changes while it still loading.

506. By Renato Araujo Oliveira Filho on 2015-12-10

Does not request contact name on ContactMap.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-10:

FAILED: Continuous integration, rev:506
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1063/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/366
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5716
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4440
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5729
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5729/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25957

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1063/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-12-11

507. By Renato Araujo Oliveira Filho on 2015-12-11

Optimize contact map.

Fetch only favorite contacts on first query, to show the favorite information as soon as possible.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-11:

FAILED: Continuous integration, rev:507
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1064/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/367
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5722
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4445
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5735
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5735/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25964

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1064/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-12-11

508. By Renato Araujo Oliveira Filho on 2015-12-11: Trunk merged.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-11:

FAILED: Continuous integration, rev:508
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1066/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/369
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5731
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4453
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5744
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5744/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25981

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1066/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-12-14

509. By Renato Araujo Oliveira Filho on 2015-12-14: Revert changes on contact map to fetch favorites first.
510. By Renato Araujo Oliveira Filho on 2015-12-14: Async load contacts on ContactMap.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-14:

FAILED: Continuous integration, rev:510
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1069/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/372
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5751
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4462
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5764
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5764/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26022

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1069/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-12-15

511. By Renato Araujo Oliveira Filho on 2015-12-15: Updated mostcalledproxymodel to work with the new history API.
512. By Renato Araujo Oliveira Filho on 2015-12-15: Show favorite section if the most called model is not empty.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-15:

FAILED: Continuous integration, rev:512
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1071/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/374
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5795
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4483
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5808
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5808/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26077

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1071/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2015-12-16

513. By Renato Araujo Oliveira Filho on 2015-12-16: Trunk merged.
514. By Renato Araujo Oliveira Filho on 2015-12-16: Trunk merged.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-16:

FAILED: Continuous integration, rev:514
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1074/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/377
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5839/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4504/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5852
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5852/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26138

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1074/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2015-12-18:

Looks good!

review: Approve

lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty updated on 2016-05-16

515. By Renato Araujo Oliveira Filho on 2015-12-18: Trunk merged.
516. By Renato Araujo Oliveira Filho on 2016-01-14: Trunk merged.
517. By Renato Araujo Oliveira Filho on 2016-01-14: Revert wrong change on last commit.
518. By Renato Araujo Oliveira Filho on 2016-01-15: Show all contacts if the header model is reseted.
519. By Renato Araujo Oliveira Filho on 2016-05-16: Trunk merged.

Unmerged revisions

519. By Renato Araujo Oliveira Filho on 2016-05-16: Trunk merged.
518. By Renato Araujo Oliveira Filho on 2016-01-15: Show all contacts if the header model is reseted.
517. By Renato Araujo Oliveira Filho on 2016-01-14: Revert wrong change on last commit.
516. By Renato Araujo Oliveira Filho on 2016-01-14: Trunk merged.
515. By Renato Araujo Oliveira Filho on 2015-12-18: Trunk merged.
514. By Renato Araujo Oliveira Filho on 2015-12-16: Trunk merged.
513. By Renato Araujo Oliveira Filho on 2015-12-16: Trunk merged.
512. By Renato Araujo Oliveira Filho on 2015-12-15: Show favorite section if the most called model is not empty.
511. By Renato Araujo Oliveira Filho on 2015-12-15: Updated mostcalledproxymodel to work with the new history API.
510. By Renato Araujo Oliveira Filho on 2015-12-14: Async load contacts on ContactMap.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Renato Araujo Oliveira Filho

Rufus

Ubuntu Phablet Team

address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/hide-favorite-if-empty into lp://qastaging/address-book-app

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers