address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/keyboard-navigation into lp://qastaging/address-book-app

keyboard-navigation
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2015-11-10

Status:	Merged
Approved by:	Bill Filler on 2015-12-11
Approved revision:	550
Merged at revision:	522
Proposed branch:	lp://qastaging/~renatofilho/address-book-app/keyboard-navigation
Merge into:	lp://qastaging/address-book-app
Diff against target:	1460 lines (+464/-156) 28 files modified src/app/addressbookapp.cpp (+17/-1) src/app/addressbookapp.h (+7/-0) src/imports/ABContactEditorPage.qml (+7/-5) src/imports/ABContactListPage.qml (+156/-32) src/imports/ABContactViewPage.qml (+12/-0) src/imports/BottomEdge.qml (+18/-1) src/imports/MainWindow.qml (+27/-1) src/imports/Settings/SettingsPage.qml (+59/-3) src/imports/Ubuntu/AddressBook/Base/ContactDetailBase.qml (+22/-8) src/imports/Ubuntu/AddressBook/Base/ContactDetailGroupBase.qml (+2/-1) src/imports/Ubuntu/AddressBook/Base/RemoveContactsDialog.qml (+10/-2) src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailAvatarEditor.qml (+1/-0) src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailGroupWithTypeEditor.qml (+12/-23) src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailNameEditor.qml (+1/-0) src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailSyncTargetEditor.qml (+7/-2) src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailWithTypeEditor.qml (+0/-1) src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml (+23/-17) src/imports/Ubuntu/AddressBook/ContactEditor/TextInputDetail.qml (+24/-10) src/imports/Ubuntu/AddressBook/ContactView/ActionButton.qml (+1/-0) src/imports/Ubuntu/AddressBook/ContactView/BasicFieldView.qml (+1/-0) src/imports/Ubuntu/AddressBook/ContactView/ContactDetailAvatarView.qml (+1/-0) src/imports/Ubuntu/AddressBook/ContactView/ContactDetailGroupWithTypeView.qml (+13/-21) src/imports/Ubuntu/AddressBook/ContactView/ContactDetailNameView.qml (+1/-1) src/imports/Ubuntu/AddressBook/ContactView/ContactDetailSyncTargetView.qml (+2/-1) src/imports/Ubuntu/AddressBook/ContactView/ContactDetailWithTypeView.qml (+3/-0) src/imports/Ubuntu/Contacts/ContactListView.qml (+26/-1) src/imports/Ubuntu/Contacts/ContactSimpleListView.qml (+7/-13) src/imports/Ubuntu/Contacts/FastScroll.qml (+4/-12)
To merge this branch:	bzr merge lp://qastaging/~renatofilho/address-book-app/keyboard-navigation
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Florian Boucault (community)			Approve on 2015-12-11
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-12-10
Bill Filler (community)		2015-11-10	Needs Fixing on 2015-11-19
Review via email: mp+277176@code.qastaging.launchpad.net

Commit message

Implement keyboard navigation for contact list.
Fix 'tab' navigation for contact editor page.
Added shortcuts for the page actions.

Description of the change

Available shortcuts:

General
=======
Esc = Back (Page stack)

Contact List
============
Ctrl + F = Search
Ctrl + N = Bottom edge (create new)

Contact View
============
Ctrl + E = Edit

Contact Editor
==============
Ctrl + S = Save
Ctrl + Delete = Delete contact

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-10:

FAILED: Continuous integration, rev:505
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1000/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/303/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5114/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5126/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1000/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-11

506. By Renato Araujo Oliveira Filho on 2015-11-11: Fixed focus on test fields.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-11:

FAILED: Continuous integration, rev:506
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1001/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/304
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5126
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4105
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5138
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5138/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25101

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1001/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-11

507. By Renato Araujo Oliveira Filho on 2015-11-11: Fixed visual for field header.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-11:

PASSED: Continuous integration, rev:507
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1002/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/305
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5128
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5140
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5140/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25103

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1002/rebuild

review: Approve (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-19

508. By Renato Araujo Oliveira Filho on 2015-11-19: Merged: ~renatofilho/address-book-app/fix-1511477
509. By Renato Araujo Oliveira Filho on 2015-11-19: Make ActionButton icons 'orange' when it has focus.
Fixed some focus misbehavior.

Revision history for this message

Bill Filler (bfiller) wrote on 2015-11-19:

Some problems:

1) Ctrl F to search, then type your search string, press enter, down arrow should navigate to first item in results list and select it

2) When at top of the contact list and press up arrow focus should go to the section selector
a) right/left arrow in section selector should navigate between sections
b) down arrow when in section selector should navigate back to list

3) After saving a new contact, the new contact should be selected in the list and scrolled into view, but this is not working and first item in list is selected instead.

4) When you create a new contact and cancel (via esc), we should either select what was previously selected or the first item, but something should be selected. Currently nothing selected and right panel is blank which is not desirable.

5) When you enter edit mode, focus needs to be placed in the first field

6) In edit mode, Up/Down arrow keys should navigate the fields on the edit screen same as tabs do

7) In edit mode, left arrow key should bring focus back to contact list, if in contact list right arrow should navigate to first field in edit mode

8) Seeing of lots of these errors in log: file:///usr/share/address-book-app/imports/ABContactEditorPage.qml:45:9: QML Action: Invalid shortcut:

review: Needs Fixing

Revision history for this message

Bill Filler (bfiller) wrote on 2015-11-19:

When press Settings button, focus should move to first item in settings list and up/down arrow should navigate, right arrow/enter should expand the item

review: Needs Fixing

Revision history for this message

Bill Filler (bfiller) wrote on 2015-11-19:

In edit mode, tab key and arrow keys should navigate to the Add Field button and Delete buttons, currently these are skipped in the navigation.

review: Needs Fixing

Revision history for this message

Bill Filler (bfiller) wrote on 2015-11-19:

In edit mode after making changes and saving the contact, the next contact in the list is selected instead of keeping the selection on the contact you just edited.

review: Needs Fixing

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-11-19:

> Some problems:
>
> 1) Ctrl F to search, then type your search string, press enter, down arrow
> should navigate to first item in results list and select it
I do not like to use arrows to navigate btw objects, the arrows is alreary consumed by the text input to navigate internally (up/down when multilines).
Could we use "Tab" here?

>
> 2) When at top of the contact list and press up arrow focus should go to the
> section selector
> a) right/left arrow in section selector should navigate between sections
> b) down arrow when in section selector should navigate back to list

This need to be implemented by SDK. We can implement WORKAROUNDS here to support that but I would like to avoid it if possible.

The correct here is set focus to the page section and it handle the arrows or tab.

>
> 3) After saving a new contact, the new contact should be selected in the list
> and scrolled into view, but this is not working and first item in list is
> selected instead.
>
> 4) When you create a new contact and cancel (via esc), we should either select
> what was previously selected or the first item, but something should be
> selected. Currently nothing selected and right panel is blank which is not
> desirable.
I will implement that.

>
> 5) When you enter edit mode, focus needs to be placed in the first field
As discussed on IRC, this is not possible at the moment since we can not detect if there is a keyboard connect to device or not.
Implementing it ad default behavior you bring regressions on the phone use case.
check: https://bugs.launchpad.net/ubuntu/+source/address-book-app/+bug/1268042

>
> 6) In edit mode, Up/Down arrow keys should navigate the fields on the edit
> screen same as tabs do
Are you sure about that? This is not how desktop apps work. Most of the apps uses Tab to go foward and "shift+tab" to go backward on items in the screen.

>
> 7) In edit mode, left arrow key should bring focus back to contact list, if in
> contact list right arrow should navigate to first field in edit mode

Left and Right arrow is already used by the fields to navigate internally on the text. The correct will be use "tab".

But again we will need some big WORKAROUNDS here, since the item that receives focus on the page will be the header and it does not handle focus very well at the moment.

>
> 8) Seeing of lots of these errors in log: file:///usr/share/address-book-
> app/imports/ABContactEditorPage.qml:45:9: QML Action: Invalid shortcut:
This is because a WORKAROUND that I am using to avoid bug #1514856.

Right now all shortcuts are enable even if the action is not active/visible, because of that I am using this WORKAROUND:

shortcut: root.active ? "Ctrl+s": ""

this warning message appear when setting the shortcut to "" (empty).

>
> 8)

> Some problems:
> 
> 1) Ctrl F to search, then type your search string, press enter, down arrow
> should navigate to first item in results list and select it
I do not like to use arrows to navigate btw objects, the arrows is alreary consumed by the text input to navigate internally (up/down when multilines). 
Could we use "Tab" here?

> 
> 2) When at top of the contact list and press up arrow focus should go to the
> section selector
> a) right/left arrow in section selector should navigate between sections
> b) down arrow when in section selector should navigate back to list

This need to be implemented by SDK. We can implement WORKAROUNDS here to support that but I would like to avoid it if possible.

The correct here is set focus to the page section and it handle the arrows or tab.

> 
> 3) After saving a new contact, the new contact should be selected in the list
> and scrolled into view, but this is not working and first item in list is
> selected instead.
> 
> 4) When you create a new contact and cancel (via esc), we should either select
> what was previously selected or the first item, but something should be
> selected. Currently nothing selected and right panel is blank which is not
> desirable.
I will implement that.

> 
> 5) When you enter edit mode, focus needs to be placed in the first field
As discussed on IRC, this is not possible at the moment since we can not detect if there is a keyboard connect to device or not. 
Implementing it ad default behavior you bring regressions on the phone use case.
check: https://bugs.launchpad.net/ubuntu/+source/address-book-app/+bug/1268042

> 
> 6) In edit mode, Up/Down arrow keys should navigate the fields on the edit
> screen same as tabs do
Are you sure about that? This is not how desktop apps work. Most of the apps uses Tab to go foward and "shift+tab" to go backward on items in the screen.

> 
> 7) In edit mode, left arrow key should bring focus back to contact list, if in
> contact list right arrow should navigate to first field in edit mode

Left and Right arrow is already used by the fields to navigate internally on the text. The correct will be use "tab".

But again we will need some big WORKAROUNDS here, since the item that receives focus on the page will be the header and it does not handle focus very well at the moment.

> 
> 8) Seeing of lots of these errors in log: file:///usr/share/address-book-
> app/imports/ABContactEditorPage.qml:45:9: QML Action: Invalid shortcut:
This is because a WORKAROUND that I am using to avoid bug #1514856.

Right now all shortcuts are enable even if the action is not active/visible, because of that I am using this WORKAROUND:

shortcut: root.active ? "Ctrl+s": ""

this warning message appear when setting the shortcut to "" (empty).

> 
> 8)

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-11-19:

> In edit mode, tab key and arrow keys should navigate to the Add Field button
> and Delete buttons, currently these are skipped in the navigation.

The current SDK does not have focus visual feedback for buttons, allowing it to receive focus can cause confusion since the user will never know which button or item has focus or not.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-19:

FAILED: Continuous integration, rev:508
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1013/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/316
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5273
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4183
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5293
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5293/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25284

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1013/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-20:

PASSED: Continuous integration, rev:509
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1014/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/317
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5282
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4191
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5302
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5302/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25303

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1014/rebuild

review: Approve (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-20

510. By Renato Araujo Oliveira Filho on 2015-11-20: Use tab to navigate to contact list from the search field.
511. By Renato Araujo Oliveira Filho on 2015-11-20: Move backwards on fields navigation when pressing 'Shif+Tab'
512. By Renato Araujo Oliveira Filho on 2015-11-20: Avoid load contact view page twice for the same contact.
513. By Renato Araujo Oliveira Filho on 2015-11-20: Make sure the contact list currentIndex does not change after editing a contact.
514. By Renato Araujo Oliveira Filho on 2015-11-20: Make sure that the app alwasy start with a selected contact when running on multi column.

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-11-20:

> Some problems:
>
> 1) Ctrl F to search, then type your search string, press enter, down arrow
> should navigate to first item in results list and select it
Fixed on rev. 510

> 3) After saving a new contact, the new contact should be selected in the list
> and scrolled into view, but this is not working and first item in list is
> selected instead.
Fixed on rev. 513

>
> 4) When you create a new contact and cancel (via esc), we should either select
> what was previously selected or the first item, but something should be
> selected. Currently nothing selected and right panel is blank which is not
> desirable.
Fixed on rev. 513

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-20:

FAILED: Continuous integration, rev:511
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1015/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/318
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5291
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4199
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5311
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5311/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25328

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1015/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-20

515. By Renato Araujo Oliveira Filho on 2015-11-20: Move focus to contact list when pressing 'down' key on search field.
516. By Renato Araujo Oliveira Filho on 2015-11-20: WORKAROUND: SDK does not allow us to disable focus for items due bug: #1514822
because of that we create a new property called '_allowFocus' that we chack before set focus for any object.
517. By Renato Araujo Oliveira Filho on 2015-11-20: Added support for shortcuts on RemoveContactsDialog.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-20:

PASSED: Continuous integration, rev:514
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1017/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/320
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5300
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4205
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5320
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5320/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25345

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1017/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-20:

FAILED: Continuous integration, rev:517
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1018/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/321
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5306
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4210
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5326
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5326/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25357

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1018/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-24

518. By Renato Araujo Oliveira Filho on 2015-11-24: Trunk merged.
519. By Renato Araujo Oliveira Filho on 2015-11-24: Fixed bottom edge visibility.
520. By Renato Araujo Oliveira Filho on 2015-11-24: Implemented keyboard navigation on settings page.
521. By Renato Araujo Oliveira Filho on 2015-11-24: Fixed duplicated shortcut while editing a contact while searching.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-24:

FAILED: Continuous integration, rev:518
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1024/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/327
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5364
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4253
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5384
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5384/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25454

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1024/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-24:

FAILED: Continuous integration, rev:521
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1025/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/328
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5365
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4254
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5385
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5385/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25459

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1025/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-24

522. By Renato Araujo Oliveira Filho on 2015-11-24: Only set focus on list item after the key down pressed.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-24:

FAILED: Continuous integration, rev:522
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1027/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/330
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5370
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4257
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5390
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5390/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25464

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1027/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-25

523. By Renato Araujo Oliveira Filho on 2015-11-25: Fixed focus chain on TextField.
524. By Renato Araujo Oliveira Filho on 2015-11-25: Fixed currentIndex change while editing a contact.
Right arrow on search field give focus to First Field on editor page.
525. By Renato Araujo Oliveira Filho on 2015-11-25: "Right" arrow give focus for first field while editing.
526. By Renato Araujo Oliveira Filho on 2015-11-25: Get rid of 'invalid shortcut' error messages.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-25:

FAILED: Continuous integration, rev:524
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1031/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/334
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5412
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4274
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5426
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5426/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25508

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1031/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-25

527. By Renato Araujo Oliveira Filho on 2015-11-25: Fixed bottom edge editor page behaviour.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-25:

FAILED: Continuous integration, rev:526
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1032/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/335
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5414
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4275
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5428
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5428/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25510

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1032/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-25:

FAILED: Continuous integration, rev:527
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1034/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/337
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5416
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4278
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5430
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5430/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25516

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1034/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-25

528. By Renato Araujo Oliveira Filho on 2015-11-25: Avoid move contact index after editing it.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-25:

FAILED: Continuous integration, rev:528
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1035/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/338
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5421
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4280
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5435
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5435/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25519

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1035/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-11-30

529. By Renato Araujo Oliveira Filho on 2015-11-30: Trunk merged.
530. By Renato Araujo Oliveira Filho on 2015-11-30: Fixed view page connections after edit a contact.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-30:

FAILED: Continuous integration, rev:529
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1036/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/339
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5491
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4317
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5505
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5505/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25633

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1036/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-11-30:

FAILED: Continuous integration, rev:530
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1037/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/340
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5499
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4319
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5513
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5513/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25635

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1037/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-12-02

531. By Renato Araujo Oliveira Filho on 2015-12-02: Update FastScroll colors.
532. By Renato Araujo Oliveira Filho on 2015-12-02: Move list to desired contact on 'positionViewAtContact'.
533. By Renato Araujo Oliveira Filho on 2015-12-02: Change selected item color to organge if the contact list has focus.
534. By Renato Araujo Oliveira Filho on 2015-12-02: Do not move focus to next item when in the bottom of the list.
535. By Renato Araujo Oliveira Filho on 2015-12-02: Avoid warning messagins while creating Connection signals with null targes.
Move focus to editor when pressing tab in the contact list.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-02:

FAILED: Continuous integration, rev:535
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1039/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/342
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5541
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4338
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5555
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5555/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25696

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1039/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-12-02

536. By Renato Araujo Oliveira Filho on 2015-12-02: Disable contact editor page while on bottom edge to avoid focus problems.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-02:

FAILED: Continuous integration, rev:536
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1040/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/343
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5546
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4343
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5560
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5560/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25710

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1040/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-12-02

537. By Renato Araujo Oliveira Filho on 2015-12-02: Centralize contact when moving the list to it.
538. By Renato Araujo Oliveira Filho on 2015-12-02: Do not select any contact while creating a new one.
539. By Renato Araujo Oliveira Filho on 2015-12-02: Deos not change the foregroundColor of item on settings page if using the single column layout.
540. By Renato Araujo Oliveira Filho on 2015-12-02: Do not move to next item on right arrow press, while in search field.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-02:

FAILED: Continuous integration, rev:538
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1042/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/345
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5552
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4348
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5566
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5566/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25720

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1042/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-12-02

541. By Renato Araujo Oliveira Filho on 2015-12-02: Removed FastScroll magnified border.
542. By Renato Araujo Oliveira Filho on 2015-12-02: Does not move focus to search field on right key press.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-02:

FAILED: Continuous integration, rev:542
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1044/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/347
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5555
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4351
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5569
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5569/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25729

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1044/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-12-03

543. By Renato Araujo Oliveira Filho on 2015-12-03: use gray background color for fasctroll tooltip.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-03:

FAILED: Continuous integration, rev:543
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1046/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/349
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5580
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4371
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5594
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5594/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25782

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1046/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-12-03

544. By Renato Araujo Oliveira Filho on 2015-12-03: Close settings page with 'Esc' or 'left arrow'.
545. By Renato Araujo Oliveira Filho on 2015-12-03: Activate actions on settings page by pressing 'right' key.
546. By Renato Araujo Oliveira Filho on 2015-12-03: Use a orange rectangle to show the selected item in the settings page.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-03:

FAILED: Continuous integration, rev:546
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1047/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/350
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5591
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4375
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5605
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5605/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25796

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1047/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Florian Boucault (fboucault) wrote on 2015-12-10:

Can you explain the purpose of forceActiveFocus() in src/imports/ABContactListPage.qml

    function reloadContact() {
        [...]
        contactList.forceActiveFocus()
    }

Revision history for this message

Florian Boucault (fboucault) wrote on 2015-12-10:

Can you explain the purpose of
    Timer {
        id: fetchNewContactTimer
        [...]
    }

Is it a workaround? if so of what?

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-12-10

547. By Renato Araujo Oliveira Filho on 2015-12-10: Fixed severam comments from reviewer;
548. By Renato Araujo Oliveira Filho on 2015-12-10: Removed 'focus' property change.
549. By Renato Araujo Oliveira Filho on 2015-12-10: Fixed selected color.
550. By Renato Araujo Oliveira Filho on 2015-12-10: Use palette color instead of hardcoded one.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-10:

FAILED: Continuous integration, rev:547
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1061/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/364
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5709
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4434
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5722
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5722/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25949

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1061/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-10:

FAILED: Continuous integration, rev:550
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1062/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/365
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5714
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4438
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5727
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5727/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25954

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1062/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Florian Boucault (fboucault) wrote on 2015-12-11:

Much better! Thank you, code is good to go.

review: Approve

lp://qastaging/~renatofilho/address-book-app/keyboard-navigation updated on 2015-12-16

551. By Renato Araujo Oliveira Filho on 2015-12-11: Trunk merged.
552. By Renato Araujo Oliveira Filho on 2015-12-11: Created 'saveActionEnabled' property to avoid problems on tests.
Used that new property instead of search for Action.
553. By Renato Araujo Oliveira Filho on 2015-12-14: Switch to keyboard visuals as soon as any key is pressed.
Avoid crash on Contact list page with 'esc' key.
554. By Renato Araujo Oliveira Filho on 2015-12-14: Avoid crash app while saving a contact using shortcut.
555. By Renato Araujo Oliveira Filho on 2015-12-14: Avoid ambiguous shortcut while search and view contact page openend.
556. By Renato Araujo Oliveira Filho on 2015-12-14: Removed workarounds necessary for bug #1518420 (fixed)
557. By Renato Araujo Oliveira Filho on 2015-12-16: Trunk merged.