address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/list-with-actions-animated into lp://qastaging/address-book-app

  1. list-with-actions-animated
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 389
Merged at revision: 428
Proposed branch: lp://qastaging/~renatofilho/address-book-app/list-with-actions-animated
Merge into: lp://qastaging/address-book-app
Diff against target: 19 lines (+3/-0)
1 file modified
src/imports/Ubuntu/Contacts/ListItemWithActions.qml (+3/-0)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/list-with-actions-animated
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+251086@code.qastaging.launchpad.net

Commit message

Create a new property 'animated';
This property is used into the list item demo page.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:388
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/756/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/59
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1552
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/658
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1382
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1550
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1550/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18386
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/524
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/774
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/774/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/756/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/address-book-app/list-with-actions-animated updated
389. By Renato Araujo Oliveira Filho

Trunk merged.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:389
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/796/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/99
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2461
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/821/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2137
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2459
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2459/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19935
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/657/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/983
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/983/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/796/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected?
 NO

Is your branch in sync with latest trunk?
 YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
 YES

Did you successfully run all tests found in your component's Test Plan on device or emulator?
 YES

If you changed the UI, was the change specified/approved by design?
 NO UI CHANGED

If you changed UI labels, did you update the pot file?
 NO LABEL CHANGED

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
 NO PACKAGE CHANGED

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
No, but not related to the changes.

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches