address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/release-04-10-2014 into lp://qastaging/address-book-app

  1. release-04-10-2014
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 299
Merged at revision: 298
Proposed branch: lp://qastaging/~renatofilho/address-book-app/release-04-10-2014
Merge into: lp://qastaging/address-book-app
Diff against target: 606 lines (+207/-100)
9 files modified
po/address-book-app.pot (+16/-11)
src/imports/Common/RemoveContactsDialog.qml (+2/-1)
src/imports/ContactEdit/ContactDetailSyncTargetEditor.qml (+1/-1)
src/imports/ContactEdit/ContactEditor.qml (+1/-1)
src/imports/ContactList/ContactListPage.qml (+2/-0)
src/imports/Ubuntu/Contacts/ContactDetailPhoneNumberTypeModel.qml (+16/-6)
src/imports/Ubuntu/Contacts/MostCalledModel.qml (+21/-17)
src/imports/Ubuntu/Contacts/mostcalledproxymodel.cpp (+130/-61)
src/imports/Ubuntu/Contacts/mostcalledproxymodel.h (+18/-2)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/release-04-10-2014
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Bill Filler (community) Needs Fixing
Review via email: mp+233436@code.qastaging.launchpad.net

Commit message

[Contacts] Avoid destroy model during a contact fetch.
[ContactList] Use green and red colors for buttons on delete dialog.
[ContactList] Show all contacts after start the search.
[Contacts] Added TRANSLATORS comments for phone labels string.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:296
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/677/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/130
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4490
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3337
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4262
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5742
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5742/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12703
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2743
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3635
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3635/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/677/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/address-book-app/release-04-10-2014 updated
297. By Renato Araujo Oliveira Filho

Use async contact fetch, and make sure to cancel async query during the destructor.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:297
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/678/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/131
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4492
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3338
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4264
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5744
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5744/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12707
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2744
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3636
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3636/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/678/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/address-book-app/release-04-10-2014 updated
298. By Renato Araujo Oliveira Filho

Clear the m_currentFetch pointer after delete it.

299. By Renato Araujo Oliveira Filho

Sort Most called list in reverse order.

Revision history for this message
Bill Filler (bfiller) wrote :

Crashes. Use silo 3 plus this MR. In dialer press contacts button on header and then search in both all and favorites. Then press x to exit search and then press Back button. Crash.

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/arm-linux-gnueabihf/libthread_db.so.1".
Core was generated by `/usr/bin/dialer-app --desktop_file_hint=/usr/share/applications/dialer-app.desk'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0xb6cafb66 in QMutex::lock() () from /usr/lib/arm-linux-gnueabihf/libQt5Core.so.5
(gdb) bt
#0 0xb6cafb66 in QMutex::lock() () from /usr/lib/arm-linux-gnueabihf/libQt5Core.so.5
#1 0xb04df6ae in QtContacts::QContactAbstractRequest::cancel() ()
   from /usr/lib/arm-linux-gnueabihf/libQt5Contacts.so.5
#2 0xac8dbe0a in MostCalledContactsModel::~MostCalledContactsModel (this=0xae47c0,
    __in_chrg=<optimized out>)
    at /tmp/buildd/address-book-app-0.2+14.10.20140828.1bzr298pkg0ubuntu5744+autopilot0/src/imports/Ubuntu/Contacts/mostcalledproxymodel.cpp:55
#3 0xac8def92 in ~QQmlElement (this=0xae47c0, __in_chrg=<optimized out>)
    at /usr/include/arm-linux-gnueabihf/qt5/QtQml/qqmlprivate.h:106
#4 QQmlPrivate::QQmlElement<MostCalledContactsModel>::~QQmlElement (this=0xae47c0,
    __in_chrg=<optimized out>) at /usr/include/arm-linux-gnueabihf/qt5/QtQml/qqmlprivate.h:106
#5 0xb6e266f2 in QObjectPrivate::deleteChildren() ()
   from /usr/lib/arm-linux-gnueabihf/libQt5Core.so.5
#6 0xb6e2bfce in QObject::~QObject() () from /usr/lib/arm-linux-gnueabihf/libQt5Core.so.5
#7 0xb68ec3fa in QQmlDelegateModel::~QQmlDelegateModel() ()
   from /usr/lib/arm-linux-gnueabihf/libQt5Qml.so.5
#8 0xb6867680 in ?? () from /usr/lib/arm-linux-gnueabihf/libQt5Qml.so.5
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
(gdb)

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:298
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/679/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/132
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4494
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3340
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4267
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5746
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5746/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12713
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2745
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3638
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3638/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/679/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:299
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/680/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/133
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4496
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3342
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4270
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5748
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5748/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12716
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2747
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3641
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3641/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/680/rebuild

review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? YES

If you changed UI labels, did you update the pot file? YES

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGE

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches