address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/release-18-09-2014 into lp://qastaging/address-book-app

release-18-09-2014
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2014-09-18

Status:

Merged

Approved by:

Bill Filler on 2014-09-23

Approved revision:

310

Merged at revision:

308

Proposed branch:

lp://qastaging/~renatofilho/address-book-app/release-18-09-2014

Merge into:

lp://qastaging/address-book-app

Diff against target:

5912 lines (+1370/-1270)

74 files modified

data/CMakeLists.txt (+5/-7)
data/address-book-app.desktop.in.in (+2/-1)
data/address-book-app.svg (+0/-120)
po/CMakeLists.txt (+12/-0)
po/address-book-app.pot (+15/-15)
po/am.po (+12/-8)
po/ar.po (+12/-8)
po/ast.po (+12/-8)
po/az.po (+0/-342)
po/bg.po (+12/-8)
po/bn.po (+9/-8)
po/br.po (+12/-8)
po/ca.po (+12/-8)
po/ckb.po (+12/-8)
po/cs.po (+12/-8)
po/da.po (+12/-8)
po/de.po (+12/-8)
po/el.po (+12/-8)
po/en_AU.po (+12/-8)
po/en_GB.po (+12/-8)
po/es.po (+12/-8)
po/eu.po (+12/-8)
po/fa.po (+12/-8)
po/fi.po (+12/-8)
po/fr.po (+12/-8)
po/gd.po (+14/-11)
po/gl.po (+12/-8)
po/he.po (+12/-8)
po/hr.po (+9/-8)
po/hu.po (+12/-8)
po/is.po (+12/-9)
po/it.po (+12/-8)
po/ja.po (+12/-8)
po/km.po (+12/-8)
po/ko.po (+12/-8)
po/lv.po (+12/-8)
po/ms.po (+12/-8)
po/my.po (+12/-8)
po/nb.po (+12/-8)
po/nl.po (+12/-8)
po/pl.po (+12/-8)
po/pt.po (+12/-8)
po/pt_BR.po (+13/-9)
po/ro.po (+12/-8)
po/ru.po (+12/-8)
po/sl.po (+12/-8)
po/sr.po (+12/-8)
po/sv.po (+12/-9)
po/ta.po (+9/-8)
po/tr.po (+12/-8)
po/ug.po (+12/-8)
po/uk.po (+12/-8)
po/zh_CN.po (+12/-8)
po/zh_HK.po (+12/-8)
po/zh_TW.po (+12/-8)
src/artwork/CMakeLists.txt (+2/-0)
src/artwork/address-book-app-symbolic.svg (+161/-0)
src/imports/ContactList/ContactListPage.qml (+35/-1)
src/imports/ContactView/ContactView.qml (+20/-35)
src/imports/Ubuntu/Contacts/ActionButton.qml (+4/-3)
src/imports/Ubuntu/Contacts/ContactDelegate.qml (+1/-0)
src/imports/Ubuntu/Contacts/ContactDetailAvatarView.qml (+45/-3)
src/imports/Ubuntu/Contacts/ContactPreviewPage.qml (+0/-1)
src/imports/Ubuntu/Contacts/ListItemWithActions.qml (+81/-32)
src/imports/Ubuntu/Contacts/PageWithBottomEdge.qml (+162/-153)
tests/autopilot/address_book_app/__init__.py (+3/-11)
tests/autopilot/address_book_app/pages/_common.py (+1/-0)
tests/autopilot/address_book_app/pages/_contact_list_page.py (+93/-91)
tests/autopilot/address_book_app/tests/__init__.py (+1/-2)
tests/autopilot/address_book_app/tests/test_create_new_from_uri.py (+0/-1)
tests/autopilot/address_book_app/tests/test_delete_contact.py (+49/-38)
tests/autopilot/address_book_app/tests/test_multiple_pick_mode.py (+2/-1)
tests/autopilot/address_book_app/tests/test_single_pick_mode.py (+2/-1)
tests/qml/tst_ListWithActions.qml (+92/-14)

To merge this branch:

bzr merge lp://qastaging/~renatofilho/address-book-app/release-18-09-2014

Related bugs:

Bug #1357945: [bottom edge] Current bottom edge hint timeout makes it difficult to read the bottom edge action	Undecided	Fix Released
Bug #1365408: Should ship a PNG icon instead of using the theme	High	Fix Released
Bug #1367325: [phone-app] empty state missing in recent view and empty address book	High	Fix Released
Bug #1368337: [dialer-app] remove progressive swipe on list itmes	Undecided	Fix Released
Bug #1368701: [address-book] remove the action-drawer from the header & distribute actions in UI	High	Fix Released
Bug #1368718: [messaging-app] improve bottom edge interaction	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Bill Filler (community)		2014-09-18	Approve on 2014-09-23
PS Jenkins bot	continuous-integration		Approve on 2014-09-19
Review via email: mp+235149@code.qastaging.launchpad.net

Commit message

[PageWithBottomEdge] Consider the drag direction to dismiss or show the bottom edge page.
[ContactListPage] Implemented empty state message on contact list, based on messaging app
[ContactViewPage] Changed avatar view visuals.
[Application] Move app icons as part of the package.

lp://qastaging/~renatofilho/address-book-app/release-18-09-2014 updated on 2014-09-18

302. By Renato Araujo Oliveira Filho on 2014-09-18: Added missing file.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-18:

FAILED: Continuous integration, rev:301
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~renatofilho/address-book-app/release-18-09-2014/+merge/235149/+edit-commit-message

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/683/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/release-18-09-2014 updated on 2014-09-18

303. By Renato Araujo Oliveira Filho on 2014-09-18

Wait some msces before start the hidden animation on bottom edge tab.

This is necessary to avoid flickering while focus is changing to different components.

304. By Renato Araujo Oliveira Filho on 2014-09-18

Move app icons as part of the package.

Avoid use themed icon as application icon.

305. By Renato Araujo Oliveira Filho on 2014-09-18

Changed avatar view visuals.
Move favorite action to avatar view area.

306. By Renato Araujo Oliveira Filho on 2014-09-18

[ListItemWithActions]

Update icon color.
Consider the swipe direction when activating actions.
Create unit test for item that does not trigger the action on mouse release.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-18:

PASSED: Continuous integration, rev:302
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/684/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/137
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4969
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3622
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4722
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6221
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6221/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13412
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3009
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3931
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3931/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/684/rebuild

review: Approve (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/release-18-09-2014 updated on 2014-09-18

307. By Renato Araujo Oliveira Filho on 2014-09-18: Reduce the favorite star size on Contact View.
308. By Renato Araujo Oliveira Filho on 2014-09-18: Updated pot file.
309. By Renato Araujo Oliveira Filho on 2014-09-18: Traslation files updated.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-18:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/685/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/address-book-app/release-18-09-2014 updated on 2014-09-18

310. By Renato Araujo Oliveira Filho on 2014-09-18: Avoid showing the "empty" message while searching or switching btw favorite and all contacts.

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2014-09-18:

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? YES

If you changed UI labels, did you update the pot file? YES

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGE

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-19:

PASSED: Continuous integration, rev:309
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/686/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/139
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4980
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3631
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4732
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6232
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6232/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13432
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3018
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3940
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3940/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/686/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-19:

PASSED: Continuous integration, rev:310
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/687/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/140
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4983
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3634
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4736
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6235
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6235/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13438
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3021
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3943
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3943/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/687/rebuild

review: Approve (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2014-09-23:

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Renato Araujo Oliveira Filho

Rufus

Ubuntu Phablet Team

address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/release-18-09-2014 into lp://qastaging/address-book-app

Commit message

Description of the change

Preview Diff

Subscribers