Merge lp://qastaging/~renatofilho/address-book-app/release-2014-08-04 into lp://qastaging/address-book-app
Proposed by
Renato Araujo Oliveira Filho
| Status: | Merged |
|---|---|
| Approved by: | Gustavo Pichorim Boiko |
| Approved revision: | 232 |
| Merged at revision: | 264 |
| Proposed branch: | lp://qastaging/~renatofilho/address-book-app/release-2014-08-04 |
| Merge into: | lp://qastaging/address-book-app |
| Diff against target: |
2845 lines (+854/-618) 64 files modified
po/CMakeLists.txt (+1/-1) src/app/addressbookapp.cpp (+9/-1) src/app/addressbookapp.h (+3/-0) src/imports/Common/ContactDetailBase.qml (+2/-2) src/imports/Common/ContactDetailGroupBase.qml (+2/-2) src/imports/Common/ContactDetailGroupWithTypeBase.qml (+1/-1) src/imports/Common/ContactDetailItem.qml (+2/-2) src/imports/Common/RemoveContactsDialog.qml (+2/-2) src/imports/ContactEdit/AddFieldDialog.qml (+2/-2) src/imports/ContactEdit/AvatarImport.qml (+2/-2) src/imports/ContactEdit/ContactDetailAvatarEditor.qml (+1/-1) src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml (+2/-2) src/imports/ContactEdit/ContactDetailNameEditor.qml (+1/-1) src/imports/ContactEdit/ContactDetailSyncTargetEditor.qml (+2/-2) src/imports/ContactEdit/ContactDetailWithTypeEditor.qml (+2/-2) src/imports/ContactEdit/ContactEditor.qml (+3/-3) src/imports/ContactEdit/TextInputDetail.qml (+1/-1) src/imports/ContactEdit/ValueSelector.qml (+3/-2) src/imports/ContactList/CMakeLists.txt (+0/-1) src/imports/ContactList/ContactListPage.qml (+214/-206) src/imports/ContactList/OnlineAccountsMessage.qml (+2/-2) src/imports/ContactList/VCardImportDialog.qml (+2/-2) src/imports/ContactShare/ContactSharePage.qml (+3/-3) src/imports/ContactView/ActionButton.qml (+1/-1) src/imports/ContactView/BasicFieldView.qml (+1/-1) src/imports/ContactView/ContactDetailAddressesView.qml (+1/-1) src/imports/ContactView/ContactDetailAvatarView.qml (+1/-1) src/imports/ContactView/ContactDetailEmailsView.qml (+1/-1) src/imports/ContactView/ContactDetailGroupWithTypeView.qml (+2/-2) src/imports/ContactView/ContactDetailNameView.qml (+1/-1) src/imports/ContactView/ContactDetailOnlineAccountsView.qml (+1/-1) src/imports/ContactView/ContactDetailOrganizationsView.qml (+1/-1) src/imports/ContactView/ContactDetailPhoneNumberView.qml (+2/-2) src/imports/ContactView/ContactDetailPhoneNumbersView.qml (+1/-1) src/imports/ContactView/ContactDetailSyncTargetView.qml (+1/-1) src/imports/ContactView/ContactDetailWithTypeView.qml (+2/-2) src/imports/ContactView/ContactFetchError.qml (+2/-2) src/imports/ContactView/ContactHeaderView.qml (+2/-2) src/imports/ContactView/ContactView.qml (+5/-5) src/imports/ContentHubProxy.qml (+0/-1) src/imports/ContentHubProxy.qml.moved (+42/-0) src/imports/MainWindow.qml (+20/-6) src/imports/Ubuntu/Contacts/CMakeLists.txt (+3/-0) src/imports/Ubuntu/Contacts/ContactAvatar.qml (+1/-1) src/imports/Ubuntu/Contacts/ContactDelegate.qml (+34/-17) src/imports/Ubuntu/Contacts/ContactDetailPickerPhoneNumberDelegate.qml (+53/-41) src/imports/Ubuntu/Contacts/ContactListView.qml (+39/-92) src/imports/Ubuntu/Contacts/ContactSimpleListView.qml (+20/-7) src/imports/Ubuntu/Contacts/DialogButtons.qml (+2/-2) src/imports/Ubuntu/Contacts/FastScroll.qml (+14/-3) src/imports/Ubuntu/Contacts/ListItemWithActions.qml (+64/-3) src/imports/Ubuntu/Contacts/ListItemWithActionsCheckBox.qml (+25/-0) src/imports/Ubuntu/Contacts/MostCalledModel.qml (+2/-0) src/imports/Ubuntu/Contacts/MultipleSelectionListView.qml (+2/-2) src/imports/Ubuntu/Contacts/PageWithBottomEdge.qml (+93/-88) src/imports/Ubuntu/Contacts/SubtitledWithColors.qml (+59/-0) src/imports/Ubuntu/Contacts/qmldir (+3/-0) tests/autopilot/address_book_app/__init__.py (+3/-3) tests/autopilot/address_book_app/pages/_common.py (+3/-4) tests/autopilot/address_book_app/pages/_contact_list_page.py (+15/-16) tests/autopilot/address_book_app/tests/test_multiple_pick_mode.py (+25/-25) tests/autopilot/address_book_app/tests/test_single_pick_mode.py (+43/-37) tests/qml/tst_ContactEditor.qml (+1/-1) tests/qml/tst_ListWithActions.qml (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~renatofilho/address-book-app/release-2014-08-04 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Gustavo Pichorim Boiko (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Visual update.
- Update import to use only Ubuntu.Components 1.1.
- Async load content hub component.
- Update ListWithActions API to support selection
- Update ContactList API, remove all|favorite header.
To post a comment you must log in.
Revision history for this message
| Renato Araujo Oliveira Filho (renatofilho) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Are there any related MPs required for this MP to build/function as expected? NO
Is your branch in sync with latest trunk? YES
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES
Did you successfully run all tests found in your component's Test Plan on device or emulator? YES
If you changed the UI, was the change specified/approved by design? YES
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGE