address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/release-30-09-2014 into lp://qastaging/address-book-app

  1. release-30-09-2014
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 311
Merged at revision: 315
Proposed branch: lp://qastaging/~renatofilho/address-book-app/release-30-09-2014
Merge into: lp://qastaging/address-book-app
Diff against target: 220 lines (+29/-20)
6 files modified
data/address-book-app.desktop.in.in (+2/-0)
po/address-book-app.pot (+18/-17)
src/imports/ContactEdit/ContactDetailAvatarEditor.qml (+3/-0)
src/imports/ContactEdit/ContactEditor.qml (+2/-1)
src/imports/ContactView/ContactFetchError.qml (+1/-1)
src/imports/Ubuntu/Contacts/PageWithBottomEdge.qml (+3/-1)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/release-30-09-2014
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+236630@code.qastaging.launchpad.net

Commit message

[PageWithBottomEdge] Make bottom edge hint invisible when not active
[ContactEditor] disable save button while avatar scale still running
[Application] Used new desktop entries to show a fake application page during the startup.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:311
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/689/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/142
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5358
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3864
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5070
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6610
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6610/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13971
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3245
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4177
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4177/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/689/rebuild

review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? NO UI CHANGED

If you changed UI labels, did you update the pot file? YES

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGED

Revision history for this message
Bill Filler (bfiller) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches