Merge lp://qastaging/~renatofilho/address-book-app/rtm-release-12-12-2014 into lp://qastaging/address-book-app/rtm-14.09
Proposed by
Renato Araujo Oliveira Filho
| Status: | Rejected |
|---|---|
| Rejected by: | Renato Araujo Oliveira Filho |
| Proposed branch: | lp://qastaging/~renatofilho/address-book-app/rtm-release-12-12-2014 |
| Merge into: | lp://qastaging/address-book-app/rtm-14.09 |
| Diff against target: |
608 lines (+282/-53) 10 files modified
CMakeLists.txt (+1/-0) debian/control (+3/-0) src/imports/ContactEdit/TextInputDetail.qml (+2/-0) src/imports/ContactList/CMakeLists.txt (+1/-0) src/imports/ContactList/ContactListPage.qml (+33/-29) src/imports/ContactList/OnlineAccountsHelper.qml (+46/-0) src/imports/ContactList/OnlineAccountsMessage.qml (+37/-22) src/imports/MainWindow.qml (+16/-2) tests/qml/CMakeLists.txt (+2/-0) tests/qml/tst_ContactList.qml (+141/-0) |
| To merge this branch: | bzr merge lp://qastaging/~renatofilho/address-book-app/rtm-release-12-12-2014 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phablet Team | Pending | ||
|
Review via email:
|
|||
Commit message
Avoid show online account dialog if the app was called from another app.
Close the online account dialog if a new contact get created.
Show "No contacts." for empty list in pick mode.
Hide search button if the list is empty.
Make the "share" and "select" buttons invisible if the contact list is empty.
To post a comment you must log in.
Unmerged revisions
- 288. By Renato Araujo Oliveira Filho
-
Show "No contacts." for empty list in pick mode.
Hide search button if the list is empty.
Make the "share" and "select" buttons invisible if the contact list is empty. - 287. By Renato Araujo Oliveira Filho
-
Avoid show online account dialog if the app was called from another app.
Close the online account dialog if a new contact get created.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
