address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/show-all-contacts-when-search-starts into lp://qastaging/~phablet-team/address-book-app/staging

  1. show-all-contacts-when-search-starts
  2. Merge into staging
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 293
Merged at revision: 293
Proposed branch: lp://qastaging/~renatofilho/address-book-app/show-all-contacts-when-search-starts
Merge into: lp://qastaging/~phablet-team/address-book-app/staging
Diff against target: 19 lines (+2/-0)
1 file modified
src/imports/ContactList/ContactListPage.qml (+2/-0)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/show-all-contacts-when-search-starts
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+232749@code.qastaging.launchpad.net

Commit message

Show all contacts after start the search.

Description of the change

HOW TO TEST
===========

Open the address-book-app
click on favorite tab
Make sure only the favorite contacts is visible
Click on search button

Expected:
==========

All contacts should appear
The tab switch "all" "favorites" should disappear

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:292
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/307/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4261
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3214
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/307
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4072
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5513
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5513/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12392
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2631
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3505
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3505/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/307/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/address-book-app/show-all-contacts-when-search-starts updated
293. By Renato Araujo Oliveira Filho

Goes back to all contacts when the search is cancelled.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:293
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/312/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4376
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3280
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/312
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4165
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5628
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5628/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12535
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2692
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3574
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3574/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/312/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches