address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/themed-icons into lp://qastaging/address-book-app

  1. themed-icons
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Rejected
Rejected by: Renato Araujo Oliveira Filho
Proposed branch: lp://qastaging/~renatofilho/address-book-app/themed-icons
Merge into: lp://qastaging/address-book-app
Diff against target: 1891 lines (+144/-1563)
18 files modified
data/CMakeLists.txt (+1/-1)
src/artwork/CMakeLists.txt (+3/-19)
src/artwork/add-detail.svg (+0/-92)
src/artwork/address-book-app.svg (+132/-0)
src/artwork/contact-call.svg (+0/-122)
src/artwork/contact-email.svg (+0/-251)
src/artwork/contact-message.svg (+0/-98)
src/artwork/contacts-app.svg (+0/-402)
src/artwork/favorite-selected.svg (+0/-105)
src/artwork/favorite-unselected.svg (+0/-113)
src/artwork/import-image.svg (+0/-189)
src/artwork/new-contact.svg (+0/-163)
src/imports/ContactList/ContactListPage.qml (+2/-2)
src/imports/ContactView/ContactDetailAddressesView.qml (+1/-1)
src/imports/ContactView/ContactDetailEmailsView.qml (+1/-1)
src/imports/ContactView/ContactDetailOrganizationsView.qml (+1/-1)
src/imports/ContactView/ContactDetailPhoneNumbersView.qml (+1/-1)
src/imports/ContactView/ContactView.qml (+2/-2)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/themed-icons
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+212682@code.qastaging.launchpad.net

Commit message

Removed unnecessary icons.
Used themed icons when possible.

To post a comment you must log in.
lp://qastaging/~renatofilho/address-book-app/themed-icons updated
155. By Renato Araujo Oliveira Filho

Removed unnecessary icons.
Used themed icons when possible.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:155
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/478/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-amd64-ci/188/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-armhf-ci/188/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-i386-ci/188/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4245/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3829/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4319/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3831/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/478/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~renatofilho/address-book-app/themed-icons updated
156. By Renato Araujo Oliveira Filho

Removed: address-book-app.svg from the default installation.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:156
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/479/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-amd64-ci/189
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-armhf-ci/189
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-armhf-ci/189/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-i386-ci/189
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4246
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3830
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3681
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4320
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4320/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3832
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3832/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6118
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/5196

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/479/rebuild

review: Approve (continuous-integration)

Unmerged revisions

156. By Renato Araujo Oliveira Filho

Removed: address-book-app.svg from the default installation.

155. By Renato Araujo Oliveira Filho

Removed unnecessary icons.
Used themed icons when possible.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches