address-book-app

Merge lp://qastaging/~renatofilho/address-book-app/update-avatar-when-name-change into lp://qastaging/~phablet-team/address-book-app/staging

  1. update-avatar-when-name-change
  2. Merge into staging
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Arthur Mello
Approved revision: 239
Merged at revision: 239
Proposed branch: lp://qastaging/~renatofilho/address-book-app/update-avatar-when-name-change
Merge into: lp://qastaging/~phablet-team/address-book-app/staging
Diff against target: 74 lines (+7/-30)
2 files modified
src/imports/ContactView/ContactDetailAvatarView.qml (+2/-28)
src/imports/Ubuntu/Contacts/ContactAvatar.qml (+5/-2)
To merge this branch: bzr merge lp://qastaging/~renatofilho/address-book-app/update-avatar-when-name-change
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+230475@code.qastaging.launchpad.net

Commit message

Fix Avatar reload function to update contact display name and avatar url.

This is necessary for contact view in case of the contact name is changed during the edit mode.

Description of the change

How to test
===========

1 Create a new contact set a avatar picture check it was saved correct
2 Edit a contact without avatar
  2.1 - Change contact name and save (check in contact view if the avatar got updated to the correct initials)
  2.2 - Set a contact avatar check if the contact avatar get update

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:239
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/278/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3395
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2666
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-amd64-ci/278
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-ci/278
        deb: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-ci/278/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/278
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3320
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4642
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4642/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11321
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2156
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2943
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2943/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/278/rebuild

review: Approve (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches