Merge lp://qastaging/~renatofilho/indicator-datetime/fix-1508438 into lp://qastaging/indicator-datetime/15.10
Proposed by
Renato Araujo Oliveira Filho
| Status: | Merged |
|---|---|
| Approved by: | Charles Kerr |
| Approved revision: | 453 |
| Merged at revision: | 446 |
| Proposed branch: | lp://qastaging/~renatofilho/indicator-datetime/fix-1508438 |
| Merge into: | lp://qastaging/indicator-datetime/15.10 |
| Diff against target: |
1145 lines (+497/-214) 20 files modified
CMakeLists.txt (+3/-2) debian/control (+2/-0) include/datetime/engine-eds.h (+3/-2) include/datetime/myself.h (+62/-0) src/CMakeLists.txt (+1/-0) src/engine-eds.cpp (+185/-196) src/main.cpp (+2/-1) src/myself.cpp (+76/-0) tests/CMakeLists.txt (+3/-1) tests/run-eds-ics-test.sh (+9/-1) tests/test-eds-ics-all-day-events.cpp (+3/-2) tests/test-eds-ics-missing-trigger.cpp (+2/-1) tests/test-eds-ics-non-attending-alarms.cpp (+79/-0) tests/test-eds-ics-non-attending-alarms.ics.in (+53/-0) tests/test-eds-ics-nonrepeating-events.cpp (+3/-2) tests/test-eds-ics-repeating-events.cpp (+3/-2) tests/test-eds-ics-repeating-valarms.cpp (+2/-1) tests/test-eds-ics-tzids-2.cpp (+2/-1) tests/test-eds-ics-tzids-utc.cpp (+2/-1) tests/test-eds-ics-tzids.cpp (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~renatofilho/indicator-datetime/fix-1508438 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Kerr (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Arthur Mello (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Ignore alarms for events marked as not attending.
Description of the change
How To test:
1 - Create a event on google calendar in the next minutes
2 - Mark the event as not attending
3 - On phone sync your calendar
3.1 - Make sure that the new event appears on your calendar app
4 - Make sure that the event does not show on indicator
5 - Wait until the event starts and make sure that no alarm is played.
To post a comment you must log in.
Revision history for this message
| Renato Araujo Oliveira Filho (renatofilho) | # |
Revision history for this message
| Charles Kerr (charlesk) | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Charles Kerr (charlesk) | # |
review:
Approve
Revision history for this message
| Charles Kerr (charlesk) wrote | # |
Revision history for this message
| Renato Araujo Oliveira Filho (renatofilho) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Charles Kerr (charlesk) | # |
review:
Approve
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Charles Kerr (charlesk) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Some change requests inline. Mostly minor, but one potential crasher and memory leak