Merge lp://qastaging/~renatofilho/indicator-datetime/ignore-alarms-with-invalid-actions into lp://qastaging/indicator-datetime

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Charles Kerr
Approved revision: 457
Merged at revision: 455
Proposed branch: lp://qastaging/~renatofilho/indicator-datetime/ignore-alarms-with-invalid-actions
Merge into: lp://qastaging/indicator-datetime
Diff against target: 1277 lines (+1209/-4)
4 files modified
src/engine-eds.cpp (+138/-4)
tests/CMakeLists.txt (+1/-0)
tests/test-eds-ics-repeating-events-with-individual-change.cpp (+101/-0)
tests/test-eds-ics-repeating-events-with-individual-change.ics.in (+969/-0)
To merge this branch: bzr merge lp://qastaging/~renatofilho/indicator-datetime/ignore-alarms-with-invalid-actions
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+297719@code.qastaging.launchpad.net

Commit message

Fetch individual detached instances for recurrence events.
Ignore alarms with invalid actions.

Description of the change

How to test:

1 - Create a new event that repeats every day starting yesterday
3 - Make sure that the event appears on the indicator
4 - Edit TODAY instance of the event, change title and time of the intance only
5 - Make sure that the indicator get update with the new event info

To post a comment you must log in.
452. By Renato Araujo Oliveira Filho

Add comments.

453. By Renato Araujo Oliveira Filho

Fetch deatached instances of events.

454. By Renato Araujo Oliveira Filho

Update comments.

455. By Renato Araujo Oliveira Filho

Create unit test

Revision history for this message
Charles Kerr (charlesk) wrote :

Comments inline

456. By Renato Araujo Oliveira Filho

Fixed typos;
Updated code based on review requests.

457. By Renato Araujo Oliveira Filho

Check for null before create std::string from uid.

Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches