Indicator Date and Time

Merge lp://qastaging/~renatofilho/indicator-datetime/url-launch-with-args into lp://qastaging/indicator-datetime/15.10

  1. url-launch-with-args
  2. Merge into trunk.15.10
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Charles Kerr
Approved revision: 446
Merged at revision: 437
Proposed branch: lp://qastaging/~renatofilho/indicator-datetime/url-launch-with-args
Merge into: lp://qastaging/indicator-datetime/15.10
Prerequisite: lp://qastaging/~charlesk/indicator-datetime/lp-1440111-friendlier-calendar-items
Diff against target: 376 lines (+70/-47)
10 files modified
include/datetime/actions-live.h (+2/-2)
include/datetime/actions.h (+2/-2)
include/datetime/appointment.h (+2/-1)
src/actions-live.cpp (+12/-7)
src/actions.cpp (+15/-14)
src/engine-eds.cpp (+10/-2)
src/menu.cpp (+7/-4)
tests/actions-mock.h (+4/-2)
tests/test-actions.cpp (+4/-4)
tests/test-live-actions.cpp (+12/-9)
To merge this branch: bzr merge lp://qastaging/~renatofilho/indicator-datetime/url-launch-with-args
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+289218@code.qastaging.launchpad.net

Commit message

[phone] calls 'calendar://startdate=<event-date>' when clicking on an event in the indicator.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:442
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~renatofilho/indicator-datetime/url-launch-with-args/+merge/289218/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/362/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/52/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/52/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/362/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:443
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~renatofilho/indicator-datetime/url-launch-with-args/+merge/289218/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/364/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/54
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/54
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/54/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/364/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:444
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/366/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/56
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/56/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/366/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM. Nice fix on the "calendar:///?startdate=%Y%m%dT%H%M%SZ" change too.

review: Approve
lp://qastaging/~renatofilho/indicator-datetime/url-launch-with-args updated
445. By Renato Araujo Oliveira Filho

Lauch calendar app using the event start time.

446. By Renato Araujo Oliveira Filho

Make sure that the ocurrence time is used to build the url to launch external application.

Revision history for this message
Charles Kerr (charlesk) wrote :

r446 is a reasonable approach for making sure the correct time is passed to the calendar. Thanks Renato :)

review: Approve
lp://qastaging/~renatofilho/indicator-datetime/url-launch-with-args updated
447. By Renato Araujo Oliveira Filho

Trunk merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches