indicator-transfer-buteo

Merge lp://qastaging/~renatofilho/indicator-transfer-buteo/initial-version into lp://qastaging/indicator-transfer-buteo

Proposed by Renato Araujo Oliveira Filho on 2015-08-04

Status:	Merged
Approved by:	Charles Kerr on 2015-09-28
Approved revision:	22
Merged at revision:	3
Proposed branch:	lp://qastaging/~renatofilho/indicator-transfer-buteo/initial-version
Merge into:	lp://qastaging/indicator-transfer-buteo
Diff against target:	2036 lines (+1915/-4) 19 files modified CMakeLists.txt (+58/-0) COPYING (+674/-0) cmake/Translations.cmake (+37/-0) cmake/lcov.cmake (+72/-0) cmake_uninstall.cmake.in (+21/-0) config.h.in (+9/-0) debian/changelog (+2/-1) debian/control (+10/-3) po/CMakeLists.txt (+3/-0) po/indicator-transfer-buteo.pot (+22/-0) src/CMakeLists.txt (+43/-0) src/buteo-plugin.cpp (+42/-0) src/buteo-source.cpp (+339/-0) src/buteo-source.h (+84/-0) src/buteo-transfer.cpp (+187/-0) src/buteo-transfer.h (+53/-0) tests/CMakeLists.txt (+34/-0) tests/buteo-syncfw.py (+121/-0) tests/tst-transfer-plugin.cpp (+104/-0)
To merge this branch:	bzr merge lp://qastaging/~renatofilho/indicator-transfer-buteo/initial-version
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Charles Kerr (community)		2015-08-04	Approve on 2015-09-28
Ken VanDine	packaging	2015-09-28	Approve on 2015-09-28
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-09-28
Review via email: mp+266949@code.qastaging.launchpad.net

Implemented transfer indicator plugin for Buteo.

Are there any related MPs required for this MP to build/function as expected?
NO

Is your branch in sync with latest trunk?
YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES

Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES

If you changed the UI, was the change specified/approved by design?
NO UI CHANGED

If you changed UI labels, did you update the pot file?
NO LABEL CHANGED

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
yes

4. By Renato Araujo Oliveira Filho on 2015-08-04: created idividual id for transfer.
5. By Renato Araujo Oliveira Filho on 2015-08-04: Updated unit test and created syncfw python service.
6. By Renato Araujo Oliveira Filho on 2015-08-05: Use online accounts api to retrieve application information related with the sync job.
7. By Renato Araujo Oliveira Filho on 2015-08-05: Use profileId as transfer.id;
8. By Renato Araujo Oliveira Filho on 2015-08-05: Fixed memory leak.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-05:

review: Needs Fixing (continuous-integration)

9. By Renato Araujo Oliveira Filho on 2015-08-05: Moved transfe state/progress update code to transfer implementation.
10. By Renato Araujo Oliveira Filho on 2015-08-05: Used source.start instead call a dbus method to start a sync on unit test.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-05:

review: Needs Fixing (continuous-integration)

11. By Renato Araujo Oliveira Filho on 2015-08-18: Fix can start function to not return true if sync finished.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-18:

review: Needs Fixing (continuous-integration)

12. By Renato Araujo Oliveira Filho on 2015-08-18: Update API.
13. By Renato Araujo Oliveira Filho on 2015-08-26: Added missing build dep.
14. By Renato Araujo Oliveira Filho on 2015-08-26: Install plugin into the correct location.