qtorganizer5-eds

Merge lp://qastaging/~renatofilho/qtorganizer5-eds/fix-1440878 into lp://qastaging/qtorganizer5-eds

  1. fix-1440878
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Charles Kerr
Approved revision: 85
Merged at revision: 81
Proposed branch: lp://qastaging/~renatofilho/qtorganizer5-eds/fix-1440878
Merge into: lp://qastaging/qtorganizer5-eds
Prerequisite: lp://qastaging/~renatofilho/qtorganizer5-eds/fix-1426519
Diff against target: 301 lines (+164/-41)
5 files modified
organizer/qorganizer-eds-engine.cpp (+13/-9)
tests/unittest/eds-base-test.cpp (+61/-0)
tests/unittest/eds-base-test.h (+3/-0)
tests/unittest/event-test.cpp (+45/-6)
tests/unittest/run-eds-test.sh (+42/-26)
To merge this branch: bzr merge lp://qastaging/~renatofilho/qtorganizer5-eds/fix-1440878
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+255725@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-04-09.

Commit message

Save a trigger for reminders with with secondsBeforeStart equals 0.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:80
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/202/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-amd64-ci/9/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/9/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-i386-ci/9/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/202/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote : Posted in a previous version of this proposal

Some inline comments below.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:83
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/203/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/10/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-i386-ci/10/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/203/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote : Posted in a previous version of this proposal

The code changes LGTM.

Approving in comments, feel free to top-approve for me once you've got the Jenkins issue sorted

review: Approve
lp://qastaging/~renatofilho/qtorganizer5-eds/fix-1440878 updated
85. By Renato Araujo Oliveira Filho

Removed test workaround.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:85
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/206/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-amd64-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/13
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-armhf-ci/13/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-vivid-i386-ci/13

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/206/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches