qtorganizer5-eds

Merge lp://qastaging/~renatofilho/qtorganizer5-eds/implemented-ocurrence-fetch into lp://qastaging/qtorganizer5-eds

implemented-ocurrence-fetch
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2014-02-25

Status:	Merged
Merged at revision:	38
Proposed branch:	lp://qastaging/~renatofilho/qtorganizer5-eds/implemented-ocurrence-fetch
Merge into:	lp://qastaging/qtorganizer5-eds
Prerequisite:	lp://qastaging/~renatofilho/qtorganizer5-eds/qt5.0.2
Diff against target:	528 lines (+329/-16) 8 files modified qorganizer/CMakeLists.txt (+2/-0) qorganizer/qorganizer-eds-engine.cpp (+135/-10) qorganizer/qorganizer-eds-engine.h (+9/-0) qorganizer/qorganizer-eds-fetchocurrencedata.cpp (+85/-0) qorganizer/qorganizer-eds-fetchocurrencedata.h (+42/-0) qorganizer/qorganizer-eds-fetchrequestdata.cpp (+8/-1) qorganizer/qorganizer-eds-fetchrequestdata.h (+1/-0) tests/unittest/recurrence-test.cpp (+47/-5)
To merge this branch:	bzr merge lp://qastaging/~renatofilho/qtorganizer5-eds/implemented-ocurrence-fetch
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2014-02-28
Michael Sheldon (community)			Approve on 2014-02-28
Ubuntu Phablet Team		2014-02-25	Pending
Review via email: mp+208193@code.qastaging.launchpad.net

Commit message

Implemented support for QOrganizerItemOccurrenceFetchRequest.

Description of the change

Are there any related MPs required for this MP to build/function as expected? YES
lp:~renatofilho/qtorganizer5-eds/qt5.0.2

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes): YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/qtorganizer5-eds) on device or emulator? YES

If you changed the UI, was the change specified/approved by design? NO UI CHANGE

If you changed the packaging (debian), did you subscribe a core-dev to this MP? NO PACKAGE CHANGE

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-25:

FAILED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/95/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-amd64-ci/82/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/82/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-i386-ci/82/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/95/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/qtorganizer5-eds/implemented-ocurrence-fetch updated on 2014-02-25

37. By Renato Araujo Oliveira Filho on 2014-02-25: Added missing files.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-25:

FAILED: Continuous integration, rev:37
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/99/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-amd64-ci/86/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/86
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/86/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-i386-ci/86/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/99/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/qtorganizer5-eds/implemented-ocurrence-fetch updated on 2014-02-25

38. By Renato Araujo Oliveira Filho on 2014-02-25: Merged parent branch.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-25:

FAILED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/101/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-amd64-ci/88
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/88/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-i386-ci/88

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/101/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-26:

PASSED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/102/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-amd64-ci/89
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/89
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/89/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-i386-ci/89

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/102/rebuild

review: Approve (continuous-integration)

Revision history for this message

Michael Sheldon (michael-sheldon) wrote on 2014-02-28:

One small issue: "Occurrence" is misspelt in a few of the new method names (e.g. itemOcurrenceAsync, itemOcurrenceAsyncGetObjectDone, itemOcurrenceAsyncListed, itemOcurrenceAsyncDone) and in the class FetchOcurrenceData.

This might lead to some confusion in the future since its spelt correctly elsewhere (e.g. QOrganizerItemOccurrenceFetchRequest)

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2014-02-28:

> One small issue: "Occurrence" is misspelt in a few of the new method names
> (e.g. itemOcurrenceAsync, itemOcurrenceAsyncGetObjectDone,
> itemOcurrenceAsyncListed, itemOcurrenceAsyncDone) and in the class
> FetchOcurrenceData.
>
> This might lead to some confusion in the future since its spelt correctly
> elsewhere (e.g. QOrganizerItemOccurrenceFetchRequest)

Thanks for the tip, I will fix that on a different MR.

Revision history for this message

Michael Sheldon (michael-sheldon) wrote on 2014-02-28:

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator? YES - based on https://wiki.ubuntu.com/Process/Merges/TestPlan/qtorganizer5-eds with extra checks for recurrent events and alarms.

Did CI run pass? YES

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut? YES

review: Approve

lp://qastaging/~renatofilho/qtorganizer5-eds/implemented-ocurrence-fetch updated on 2014-02-28

39. By Renato Araujo Oliveira Filho on 2014-02-28: Fixed due date field for recurrence todo events.
40. By Renato Araujo Oliveira Filho on 2014-02-28: Put back some tests removed by mistake.
41. By Renato Araujo Oliveira Filho on 2014-02-28: Reverted wrong commits