Merge lp://qastaging/~renatofilho/qtorganizer5-eds/thread-parse into lp://qastaging/qtorganizer5-eds

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 98
Merged at revision: 91
Proposed branch: lp://qastaging/~renatofilho/qtorganizer5-eds/thread-parse
Merge into: lp://qastaging/qtorganizer5-eds
Prerequisite: lp://qastaging/~renatofilho/qtorganizer5-eds/filter-collection-query
Diff against target: 785 lines (+359/-34)
13 files modified
organizer/CMakeLists.txt (+2/-0)
organizer/qorganizer-eds-engine.cpp (+42/-21)
organizer/qorganizer-eds-engine.h (+9/-0)
organizer/qorganizer-eds-fetchrequestdata.cpp (+59/-8)
organizer/qorganizer-eds-fetchrequestdata.h (+25/-1)
organizer/qorganizer-eds-parseeventthread.cpp (+48/-0)
organizer/qorganizer-eds-parseeventthread.h (+61/-0)
organizer/qorganizer-eds-requestdata.cpp (+15/-1)
organizer/qorganizer-eds-requestdata.h (+6/-1)
tests/unittest/cancel-operation-test.cpp (+2/-0)
tests/unittest/eds-base-test.cpp (+1/-0)
tests/unittest/fetchitem-test.cpp (+6/-2)
tests/unittest/parseecal-test.cpp (+83/-0)
To merge this branch: bzr merge lp://qastaging/~renatofilho/qtorganizer5-eds/thread-parse
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+255873@code.qastaging.launchpad.net

Commit message

Implemented event parse EDS -> QOrganizer in a thread to avoid main thread be blocked.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
91. By Renato Araujo Oliveira Filho

Added minssing files.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
92. By Renato Araujo Oliveira Filho

Make sure to delete request-data only after emit the finish signal.

We need to wait for the parse thread before emit the signal.

93. By Renato Araujo Oliveira Filho

Make sure that the request data is not destroyed immediately after call finish function.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
94. By Renato Araujo Oliveira Filho

Added debug helper functions.

95. By Renato Araujo Oliveira Filho

Code cleanup.

96. By Renato Araujo Oliveira Filho

Added check to make sure that all request get destroyed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
97. By Renato Araujo Oliveira Filho

Parent merged.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
98. By Renato Araujo Oliveira Filho

Parent merged.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches