qtorganizer5-eds

Merge lp://qastaging/~renatofilho/qtorganizer5-eds/tz-support into lp://qastaging/qtorganizer5-eds

tz-support
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2014-04-01

Status:

Merged

Approved by:

Michael Sheldon on 2014-04-03

Approved revision:

Merged at revision:

Proposed branch:

lp://qastaging/~renatofilho/qtorganizer5-eds/tz-support

Merge into:

lp://qastaging/qtorganizer5-eds

Diff against target:

305 lines (+109/-35)

4 files modified

qorganizer/qorganizer-eds-engine.cpp (+55/-24)
qorganizer/qorganizer-eds-engine.h (+2/-1)
tests/unittest/event-test.cpp (+40/-0)
tests/unittest/recurrence-test.cpp (+12/-10)

To merge this branch:

bzr merge lp://qastaging/~renatofilho/qtorganizer5-eds/tz-support

Critical

Invalid

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Sheldon (community)		2014-04-01	Approve on 2014-04-02
PS Jenkins bot	continuous-integration		Approve on 2014-04-02
Review via email: mp+213714@code.qastaging.launchpad.net

Commit message

Initial implementation of time zone support.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-04-01:

FAILED: Continuous integration, rev:45
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/122/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-amd64-ci/111/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/109/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-i386-ci/109/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/122/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~renatofilho/qtorganizer5-eds/tz-support updated on 2014-04-01

46. By Renato Araujo Oliveira Filho on 2014-04-01: Fixed tzid set when time zone is null.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-04-01:

PASSED: Continuous integration, rev:46
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/123/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-amd64-ci/112
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/110
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/110/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-i386-ci/110

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtorganizer5-eds-ci/123/rebuild

review: Approve (continuous-integration)

lp://qastaging/~renatofilho/qtorganizer5-eds/tz-support updated on 2014-04-02

47. By Renato Araujo Oliveira Filho on 2014-04-02: Fixed datetime conversion when using timezones.

Revision history for this message

Alan Pope 🍺🐧🐱 🦄 (popey) wrote on 2014-04-02:

Tested this on my desktop which has multiple calendars synced (personal and work) and all events (created by people in different timezones) appeared in the right place.

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2014-04-02:

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes): YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/qtorganizer5-eds) on device or emulator? YES

If you changed the UI, was the change specified/approved by design? NO UI CHANGE

If you changed the packaging (debian), did you subscribe a core-dev to this MP? NO PACKAGE CHANGE

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-04-02:

PASSED: Continuous integration, rev:47
http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-ci/124/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-amd64-ci/113
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/111
        deb: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-armhf-ci/111/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtorganizer5-eds-trusty-i386-ci/111