Merge lp://qastaging/~renatofilho/sync-monitor/fix-1579936 into lp://qastaging/sync-monitor
Proposed by
Renato Araujo Oliveira Filho
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michael Zanetti | ||||
| Approved revision: | 62 | ||||
| Merged at revision: | 61 | ||||
| Proposed branch: | lp://qastaging/~renatofilho/sync-monitor/fix-1579936 | ||||
| Merge into: | lp://qastaging/sync-monitor | ||||
| Diff against target: |
21 lines (+2/-2) 1 file modified
src/sync-daemon.cpp (+2/-2) |
||||
| To merge this branch: | bzr merge lp://qastaging/~renatofilho/sync-monitor/fix-1579936 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Zanetti (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Make sure that signal 'syncAboutToStart' is fired before 'syncDone';
Description of the change
HOW TO TEST
============
1- Make sure that your device is connected on 3g/4g (disconnect from wifi)
2- Do changes on your google calendar from the browser
3- Wait until the account polld does the autosync
3.1 - Check sync-monitor log for the message: "Device is offline we will skip the sync."
Expected result:
===============
Wake lock is released
Current result:
===============
Wake lock still live until the wifi sync
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I don't think the explicit Qt::DirectConne
Anyhow, the moving around of the emits syncAboutToStart() before the actual sync() call definitely makes sense. Also I have tested this here and it fixes my wakelock situation indeed.