sync-monitor

Merge lp://qastaging/~renatofilho/sync-monitor/initial-release into lp://qastaging/sync-monitor

  1. initial-release
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Merged at revision: 18
Proposed branch: lp://qastaging/~renatofilho/sync-monitor/initial-release
Merge into: lp://qastaging/sync-monitor
Diff against target: 71424 lines (+69403/-486)
205 files modified
.bzr-builddeb/default.conf (+2/-0)
.bzrignore (+2/-0)
3rd_party/CMakeLists.txt (+1/-0)
3rd_party/gmock/CMakeLists.txt (+171/-0)
3rd_party/gmock/gtest/CHANGES (+153/-0)
3rd_party/gmock/gtest/CMakeLists.txt (+250/-0)
3rd_party/gmock/gtest/CONTRIBUTORS (+37/-0)
3rd_party/gmock/gtest/Makefile.am (+305/-0)
3rd_party/gmock/gtest/README (+435/-0)
3rd_party/gmock/gtest/cmake/internal_utils.cmake (+227/-0)
3rd_party/gmock/gtest/codegear/gtest_all.cc (+38/-0)
3rd_party/gmock/gtest/codegear/gtest_link.cc (+40/-0)
3rd_party/gmock/gtest/configure.ac (+68/-0)
3rd_party/gmock/gtest/include/gtest/gtest-death-test.h (+294/-0)
3rd_party/gmock/gtest/include/gtest/gtest-message.h (+250/-0)
3rd_party/gmock/gtest/include/gtest/gtest-param-test.h (+1421/-0)
3rd_party/gmock/gtest/include/gtest/gtest-param-test.h.pump (+487/-0)
3rd_party/gmock/gtest/include/gtest/gtest-printers.h (+855/-0)
3rd_party/gmock/gtest/include/gtest/gtest-spi.h (+232/-0)
3rd_party/gmock/gtest/include/gtest/gtest-test-part.h (+179/-0)
3rd_party/gmock/gtest/include/gtest/gtest-typed-test.h (+259/-0)
3rd_party/gmock/gtest/include/gtest/gtest.h (+2291/-0)
3rd_party/gmock/gtest/include/gtest/gtest_pred_impl.h (+358/-0)
3rd_party/gmock/gtest/include/gtest/gtest_prod.h (+58/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-death-test-internal.h (+319/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-filepath.h (+206/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-internal.h (+1147/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-linked_ptr.h (+233/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-param-util-generated.h (+5143/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-param-util-generated.h.pump (+301/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-param-util.h (+619/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-port.h (+1947/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-string.h (+167/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-tuple.h (+1012/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-tuple.h.pump (+339/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-type-util.h (+3331/-0)
3rd_party/gmock/gtest/include/gtest/internal/gtest-type-util.h.pump (+297/-0)
3rd_party/gmock/gtest/m4/acx_pthread.m4 (+363/-0)
3rd_party/gmock/gtest/m4/gtest.m4 (+74/-0)
3rd_party/gmock/gtest/make/Makefile (+82/-0)
3rd_party/gmock/gtest/samples/prime_tables.h (+123/-0)
3rd_party/gmock/gtest/samples/sample1.cc (+68/-0)
3rd_party/gmock/gtest/samples/sample1.h (+43/-0)
3rd_party/gmock/gtest/samples/sample10_unittest.cc (+144/-0)
3rd_party/gmock/gtest/samples/sample1_unittest.cc (+153/-0)
3rd_party/gmock/gtest/samples/sample2.cc (+56/-0)
3rd_party/gmock/gtest/samples/sample2.h (+85/-0)
3rd_party/gmock/gtest/samples/sample2_unittest.cc (+109/-0)
3rd_party/gmock/gtest/samples/sample3-inl.h (+172/-0)
3rd_party/gmock/gtest/samples/sample3_unittest.cc (+151/-0)
3rd_party/gmock/gtest/samples/sample4.cc (+46/-0)
3rd_party/gmock/gtest/samples/sample4.h (+53/-0)
3rd_party/gmock/gtest/samples/sample4_unittest.cc (+45/-0)
3rd_party/gmock/gtest/samples/sample5_unittest.cc (+199/-0)
3rd_party/gmock/gtest/samples/sample6_unittest.cc (+224/-0)
3rd_party/gmock/gtest/samples/sample7_unittest.cc (+130/-0)
3rd_party/gmock/gtest/samples/sample8_unittest.cc (+173/-0)
3rd_party/gmock/gtest/samples/sample9_unittest.cc (+160/-0)
3rd_party/gmock/gtest/scripts/fuse_gtest_files.py (+250/-0)
3rd_party/gmock/gtest/scripts/gen_gtest_pred_impl.py (+730/-0)
3rd_party/gmock/gtest/scripts/gtest-config.in (+274/-0)
3rd_party/gmock/gtest/scripts/pump.py (+855/-0)
3rd_party/gmock/gtest/scripts/test/Makefile (+59/-0)
3rd_party/gmock/gtest/scripts/upload.py (+1387/-0)
3rd_party/gmock/gtest/scripts/upload_gtest.py (+78/-0)
3rd_party/gmock/gtest/src/gtest-all.cc (+48/-0)
3rd_party/gmock/gtest/src/gtest-death-test.cc (+1344/-0)
3rd_party/gmock/gtest/src/gtest-filepath.cc (+382/-0)
3rd_party/gmock/gtest/src/gtest-internal-inl.h (+1218/-0)
3rd_party/gmock/gtest/src/gtest-port.cc (+805/-0)
3rd_party/gmock/gtest/src/gtest-printers.cc (+363/-0)
3rd_party/gmock/gtest/src/gtest-test-part.cc (+110/-0)
3rd_party/gmock/gtest/src/gtest-typed-test.cc (+110/-0)
3rd_party/gmock/gtest/src/gtest.cc (+4961/-0)
3rd_party/gmock/gtest/src/gtest_main.cc (+38/-0)
3rd_party/gmock/gtest/test/gtest-death-test_ex_test.cc (+93/-0)
3rd_party/gmock/gtest/test/gtest-death-test_test.cc (+1368/-0)
3rd_party/gmock/gtest/test/gtest-filepath_test.cc (+680/-0)
3rd_party/gmock/gtest/test/gtest-linked_ptr_test.cc (+154/-0)
3rd_party/gmock/gtest/test/gtest-listener_test.cc (+310/-0)
3rd_party/gmock/gtest/test/gtest-message_test.cc (+159/-0)
3rd_party/gmock/gtest/test/gtest-options_test.cc (+215/-0)
3rd_party/gmock/gtest/test/gtest-param-test2_test.cc (+65/-0)
3rd_party/gmock/gtest/test/gtest-param-test_test.cc (+904/-0)
3rd_party/gmock/gtest/test/gtest-param-test_test.h (+57/-0)
3rd_party/gmock/gtest/test/gtest-port_test.cc (+1253/-0)
3rd_party/gmock/gtest/test/gtest-printers_test.cc (+1566/-0)
3rd_party/gmock/gtest/test/gtest-test-part_test.cc (+208/-0)
3rd_party/gmock/gtest/test/gtest-tuple_test.cc (+320/-0)
3rd_party/gmock/gtest/test/gtest-typed-test2_test.cc (+45/-0)
3rd_party/gmock/gtest/test/gtest-typed-test_test.cc (+360/-0)
3rd_party/gmock/gtest/test/gtest-typed-test_test.h (+66/-0)
3rd_party/gmock/gtest/test/gtest-unittest-api_test.cc (+341/-0)
3rd_party/gmock/gtest/test/gtest_all_test.cc (+47/-0)
3rd_party/gmock/gtest/test/gtest_break_on_failure_unittest.py (+218/-0)
3rd_party/gmock/gtest/test/gtest_break_on_failure_unittest_.cc (+88/-0)
3rd_party/gmock/gtest/test/gtest_catch_exceptions_test.py (+223/-0)
3rd_party/gmock/gtest/test/gtest_catch_exceptions_test_.cc (+311/-0)
3rd_party/gmock/gtest/test/gtest_color_test.py (+130/-0)
3rd_party/gmock/gtest/test/gtest_color_test_.cc (+71/-0)
3rd_party/gmock/gtest/test/gtest_env_var_test.py (+103/-0)
3rd_party/gmock/gtest/test/gtest_env_var_test_.cc (+126/-0)
3rd_party/gmock/gtest/test/gtest_environment_test.cc (+192/-0)
3rd_party/gmock/gtest/test/gtest_filter_unittest.py (+633/-0)
3rd_party/gmock/gtest/test/gtest_filter_unittest_.cc (+140/-0)
3rd_party/gmock/gtest/test/gtest_help_test.py (+172/-0)
3rd_party/gmock/gtest/test/gtest_help_test_.cc (+46/-0)
3rd_party/gmock/gtest/test/gtest_list_tests_unittest.py (+207/-0)
3rd_party/gmock/gtest/test/gtest_list_tests_unittest_.cc (+157/-0)
3rd_party/gmock/gtest/test/gtest_main_unittest.cc (+45/-0)
3rd_party/gmock/gtest/test/gtest_no_test_unittest.cc (+56/-0)
3rd_party/gmock/gtest/test/gtest_output_test.py (+335/-0)
3rd_party/gmock/gtest/test/gtest_output_test_.cc (+1034/-0)
3rd_party/gmock/gtest/test/gtest_output_test_golden_lin.txt (+720/-0)
3rd_party/gmock/gtest/test/gtest_pred_impl_unittest.cc (+2427/-0)
3rd_party/gmock/gtest/test/gtest_prod_test.cc (+57/-0)
3rd_party/gmock/gtest/test/gtest_repeat_test.cc (+253/-0)
3rd_party/gmock/gtest/test/gtest_shuffle_test.py (+325/-0)
3rd_party/gmock/gtest/test/gtest_shuffle_test_.cc (+103/-0)
3rd_party/gmock/gtest/test/gtest_sole_header_test.cc (+57/-0)
3rd_party/gmock/gtest/test/gtest_stress_test.cc (+256/-0)
3rd_party/gmock/gtest/test/gtest_test_utils.py (+305/-0)
3rd_party/gmock/gtest/test/gtest_throw_on_failure_ex_test.cc (+92/-0)
3rd_party/gmock/gtest/test/gtest_throw_on_failure_test.py (+171/-0)
3rd_party/gmock/gtest/test/gtest_throw_on_failure_test_.cc (+72/-0)
3rd_party/gmock/gtest/test/gtest_uninitialized_test.py (+70/-0)
3rd_party/gmock/gtest/test/gtest_uninitialized_test_.cc (+43/-0)
3rd_party/gmock/gtest/test/gtest_unittest.cc (+7415/-0)
3rd_party/gmock/gtest/test/gtest_xml_outfile1_test_.cc (+49/-0)
3rd_party/gmock/gtest/test/gtest_xml_outfile2_test_.cc (+49/-0)
3rd_party/gmock/gtest/test/gtest_xml_outfiles_test.py (+132/-0)
3rd_party/gmock/gtest/test/gtest_xml_output_unittest.py (+307/-0)
3rd_party/gmock/gtest/test/gtest_xml_output_unittest_.cc (+181/-0)
3rd_party/gmock/gtest/test/gtest_xml_test_utils.py (+194/-0)
3rd_party/gmock/gtest/test/production.cc (+36/-0)
3rd_party/gmock/gtest/test/production.h (+55/-0)
3rd_party/gmock/gtest/xcode/Config/DebugProject.xcconfig (+30/-0)
3rd_party/gmock/gtest/xcode/Config/FrameworkTarget.xcconfig (+17/-0)
3rd_party/gmock/gtest/xcode/Config/General.xcconfig (+41/-0)
3rd_party/gmock/gtest/xcode/Config/ReleaseProject.xcconfig (+32/-0)
3rd_party/gmock/gtest/xcode/Config/StaticLibraryTarget.xcconfig (+18/-0)
3rd_party/gmock/gtest/xcode/Config/TestTarget.xcconfig (+8/-0)
3rd_party/gmock/gtest/xcode/Resources/Info.plist (+30/-0)
3rd_party/gmock/gtest/xcode/Samples/FrameworkSample/Info.plist (+28/-0)
3rd_party/gmock/gtest/xcode/Samples/FrameworkSample/runtests.sh (+62/-0)
3rd_party/gmock/gtest/xcode/Samples/FrameworkSample/widget.cc (+63/-0)
3rd_party/gmock/gtest/xcode/Samples/FrameworkSample/widget.h (+59/-0)
3rd_party/gmock/gtest/xcode/Samples/FrameworkSample/widget_test.cc (+68/-0)
3rd_party/gmock/gtest/xcode/Scripts/runtests.sh (+65/-0)
3rd_party/gmock/gtest/xcode/Scripts/versiongenerate.py (+100/-0)
3rd_party/gmock/src/gmock-all.cc (+47/-0)
3rd_party/gmock/src/gmock-cardinalities.cc (+156/-0)
3rd_party/gmock/src/gmock-internal-utils.cc (+174/-0)
3rd_party/gmock/src/gmock-matchers.cc (+137/-0)
3rd_party/gmock/src/gmock-spec-builders.cc (+813/-0)
3rd_party/gmock/src/gmock.cc (+182/-0)
3rd_party/gmock/src/gmock_main.cc (+54/-0)
CMakeLists.txt (+4/-0)
accounts/applications/CMakeLists.txt (+4/-4)
accounts/applications/calendar-sync.application.in (+7/-6)
accounts/applications/contacts-sync.application.in (+7/-6)
accounts/services/CMakeLists.txt (+4/-0)
accounts/services/google-caldav.service.in (+2/-1)
accounts/services/google-carddav.service.in (+2/-1)
accounts/services/yahoo-caldav.service.in (+15/-0)
accounts/services/yahoo-carddav.service.in (+15/-0)
config.h.in (+4/-0)
data/CMakeLists.txt (+8/-0)
data/com.canonical.SyncMonitor.service.in (+3/-0)
debian/changelog (+1/-1)
debian/control (+19/-17)
debian/copyright (+63/-7)
debian/rules (+0/-4)
debian/sync-monitor.install (+3/-1)
src/CMakeLists.txt (+31/-9)
src/address-book-trigger.cpp (+0/-71)
src/address-book-trigger.h (+0/-45)
src/eds-helper.cpp (+174/-0)
src/eds-helper.h (+59/-0)
src/main.cpp (+2/-0)
src/notify-message-mock.cpp (+2/-1)
src/notify-message-notify.cpp (+3/-2)
src/notify-message.h (+1/-1)
src/provider-template.cpp (+78/-0)
src/provider-template.h (+42/-0)
src/sync-account.cpp (+369/-176)
src/sync-account.h (+44/-23)
src/sync-configure.cpp (+241/-0)
src/sync-configure.h (+65/-0)
src/sync-daemon.cpp (+243/-84)
src/sync-daemon.h (+35/-14)
src/sync-dbus.cpp (+100/-0)
src/sync-dbus.h (+101/-0)
src/sync-queue.cpp (+105/-0)
src/sync-queue.h (+47/-0)
src/syncevolution-session-proxy.cpp (+17/-10)
src/syncevolution-session-proxy.h (+1/-1)
templates/CMakeLists.txt (+8/-0)
templates/google.conf (+13/-0)
templates/yahoo.conf (+5/-0)
tests/CMakeLists.txt (+1/-0)
tests/unittest/CMakeLists.txt (+26/-0)
tests/unittest/sync-account-mock.h (+37/-0)
tests/unittest/sync-queue-test.cpp (+201/-0)
upstart/sync-monitor.conf.in (+1/-1)
To merge this branch: bzr merge lp://qastaging/~renatofilho/sync-monitor/initial-release
Reviewer Review Type Date Requested Status
Timo Jyrinki Approve
PS Jenkins bot continuous-integration Approve
Bill Filler (community) Needs Fixing
Review via email: mp+208886@code.qastaging.launchpad.net

Commit message

Updated package version.

Description of the change

HOW TO TEST THIS:
=================

1) Install the following branches:
* https://code.launchpad.net/~renatofilho/address-book-service/disable-folks-linking/+merge/213550

2) Update folks library:
add-apt-repository ppa:phablet-team
apt-get update
apt-get install libfolks-eds25 folks-common libfolks25

3) Install sync-monitor dependencies:
apt-get install syncevolution-dbus syncevolution-provider-uoa

4) Install this branch
2) Reboot the device
3) Add a google account using the online-accounts tool on system-settings
4) Wait for the sync

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:19
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/3/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/3/rebuild

review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

some comments:
1) deleting a contact on the phone did not delete it from google (editing on phone did work though). If it's deleted on the phone it should be deleted from google as well. The next time a sync occurs the contact shows back up on the phone.
2) whenever I modified a contact on the phone I see "Start sync account" notification. I think we should only display this message the first time sync is enabled and we're performing the big sync. Don't think we need it after that

review: Needs Fixing
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
20. By Renato Araujo Oliveira Filho

Only show notify messages for slow sync (first sync).

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:20
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/4/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/4/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
21. By Renato Araujo Oliveira Filho

Make sure to run "slow" sync only in the first sync or after a sync error.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:21
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/5/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
22. By Renato Araujo Oliveira Filho

Renamed service type.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:22
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/6

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/6/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
23. By Renato Araujo Oliveira Filho

Increased the service timeout to one minute.

24. By Renato Araujo Oliveira Filho

Extended sync monitor to support new accounts type not only google.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:24
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/7/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/7/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
25. By Renato Araujo Oliveira Filho

debian package.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:25
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/8
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/8/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/8

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/8/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
26. By Renato Araujo Oliveira Filho

Replaced dbus address-book DBUS calls with the QtContacts module.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:26
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/9/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/9/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/9/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/9/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/9/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
27. By Renato Araujo Oliveira Filho

Check for target and sync configs individually.

28. By Renato Araujo Oliveira Filho

Configure remote database based on template file.

29. By Renato Araujo Oliveira Filho

Added basic support for sync calendars.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:29
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/10/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/10/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/10/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/10/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/10/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
30. By Renato Araujo Oliveira Filho

Added missing files.

31. By Renato Araujo Oliveira Filho

Added new qtorganizer and qtcontacts as build dependency.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:31
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/11/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/11
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/11/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/11

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/11/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
32. By Renato Araujo Oliveira Filho

Export sync monitor dbus interface.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:32
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/12/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/12
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/12/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/12

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/12/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
33. By Renato Araujo Oliveira Filho

Added dbus service file.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:33
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/13/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/13
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/13/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/13

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/13/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
34. By Renato Araujo Oliveira Filho

Disabled sync by default on configure file.
Fixed calendar sync.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:34
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/14/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/14
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/14
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/14/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/14

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/14/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
35. By Renato Araujo Oliveira Filho

Added more debug messages.
Fixed account state when a sync error occur.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:35
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/15/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/15
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/15/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/15

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/15/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
36. By Renato Araujo Oliveira Filho

Fixed account enable/disable.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/16/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/16
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/16/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/16

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/16/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
37. By Renato Araujo Oliveira Filho

Check last sync status to determine the sync mode.

Added more debug messages.
Show error message in case of a fail during the sync.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:37
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/17/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/17
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/17
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/17/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/17

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/17/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:37
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/18/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/18
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/18/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/18

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/18/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
38. By Renato Araujo Oliveira Filho

Removed debug message.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/19/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/19
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/19/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/19

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/19/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/20/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/20
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/20/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/20

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/20/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
39. By Renato Araujo Oliveira Filho

Improved debug messages.

40. By Renato Araujo Oliveira Filho

Fixed elapsed time.

41. By Renato Araujo Oliveira Filho

Extend sync status list.
Used "two-way" sync as default for unknown errors.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:41
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/21/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/21/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/21

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/21/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
42. By Renato Araujo Oliveira Filho

Removed sync on startup.
Avoid sync when address book restart.

43. By Renato Araujo Oliveira Filho

Write a better comment about the work around to avoid early syncs.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:42
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/22/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/22
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/22/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/22

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/22/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:43
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/23/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/23/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/23

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/23/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
44. By Renato Araujo Oliveira Filho

Added debug message with more information about last sync status.

45. By Renato Araujo Oliveira Filho

Added more info about the sync result at the end of the sync.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:45
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/24/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/24
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/24/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/24

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/24/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
46. By Renato Araujo Oliveira Filho

Added build file necessary for CI job.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:46
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/25/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/25
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/25/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/25

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/25/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
47. By Renato Araujo Oliveira Filho

Only sync the source that has changed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:47
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/26
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/26
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/26/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/26

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/26/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
48. By Renato Araujo Oliveira Filho

Export a list of enabled service on dbus.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:48
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/27/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/27
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/27/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/27

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/27/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
49. By Renato Araujo Oliveira Filho

Check calendar events change to sync only the changed account.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:49
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/28/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/28
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/28/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/28

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/28/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
50. By Renato Araujo Oliveira Filho

Created unit test for SyncQueue.

51. By Renato Araujo Oliveira Filho

Removed wrong files.

52. By Renato Araujo Oliveira Filho

Added gmock source code. (necessary in tests)

53. By Renato Araujo Oliveira Filho

Ignore files.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:54
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/29/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/29
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/29
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/29/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/29

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/29/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
54. By Renato Araujo Oliveira Filho

Revert changes on sync-queue, instead use virtual methods on SyncAccount to make it easy to test.

55. By Renato Araujo Oliveira Filho

Show service icon on notify message.

56. By Renato Araujo Oliveira Filho

Removed build dir.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:56
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/30/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/30/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/30/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/30/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/30/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:56
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/31/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/31/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/31/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/31/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/31/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
57. By Renato Araujo Oliveira Filho

Remove debug message.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:57
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/32/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/32
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/32/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/32

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/32/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
58. By Renato Araujo Oliveira Filho

Fixed debian/copyright

59. By Renato Araujo Oliveira Filho

Change default sync interval to one minute.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:58
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/33/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/33
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/33/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/33

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/33/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
60. By Renato Araujo Oliveira Filho

Start sync immediately after add a new account or enable it.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:59
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/35/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/35
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/35/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/35

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/35/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
61. By Renato Araujo Oliveira Filho

Basic preliminary packaging review. Fixed packaging, copyright and changed the install directory (/usr/libdir is not valid in Ubuntu)

62. By Renato Araujo Oliveira Filho

Fixed sync-monitor path in dbus service file.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:60
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/37/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/37
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/37/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/37

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/37/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/sync-monitor/initial-release updated
63. By Renato Araujo Oliveira Filho

Fixed upstart exec path.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:62
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/38/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/38
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/38
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/38/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/38

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/38/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:63
http://jenkins.qa.ubuntu.com/job/sync-monitor-ci/39/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-amd64-ci/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/39
        deb: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-armhf-ci/39/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/sync-monitor-trusty-i386-ci/39

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/sync-monitor-ci/39/rebuild

review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Looks great! However, LGPL license file is also needed to be included, for example:
wget 'https://qt.gitorious.org/qt/qtbase/raw/6b2b0cd41b5a75f5a1f6e8c0313f2e9cce55e64e:LICENSE.LGPL' -O LICENSE.LGPL

review: Needs Fixing
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Also Didier spotted this one:
W: sync-monitor source: syntax-error-in-dep5-copyright line 58: Continuation line outside a paragraph (maybe line 57 should be " .").

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Aside from the above ^ there are also small opportunities of polishing in the descriptions of the packages:
I: sync-monitor source: duplicate-short-description sync-monitor sync-monitor-uoa
I: sync-monitor: extended-description-is-probably-too-short
I: sync-monitor-uoa: extended-description-is-probably-too-short

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Ok, no further actions needed, the ones mentioned were handled at:
https://code.launchpad.net/~timo-jyrinki/sync-monitor/last_bits_of_packaging_polishing/+merge/214881

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches