Merge lp://qastaging/~renatofilho/sync-monitor/sync-by-acount into lp://qastaging/sync-monitor

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Michael Sheldon
Approved revision: 60
Merged at revision: 53
Proposed branch: lp://qastaging/~renatofilho/sync-monitor/sync-by-acount
Merge into: lp://qastaging/sync-monitor
Prerequisite: lp://qastaging/~renatofilho/sync-monitor/revert-contact-service-file-removal
Diff against target: 277 lines (+117/-5)
6 files modified
src/sync-account.cpp (+36/-1)
src/sync-account.h (+8/-0)
src/sync-daemon.cpp (+61/-4)
src/sync-daemon.h (+2/-0)
src/sync-dbus.cpp (+5/-0)
src/sync-dbus.h (+5/-0)
To merge this branch: bzr merge lp://qastaging/~renatofilho/sync-monitor/sync-by-acount
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
Review via email: mp+273917@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-10-08.

Commit message

Export 'syncAcount' function over DBUs to be used during the account migration.

To post a comment you must log in.
54. By Renato Araujo Oliveira Filho

Fix typo.

55. By Renato Araujo Oliveira Filho

Make sure that account sync finished is fired after the sync.

56. By Renato Araujo Oliveira Filho

Fire syncError if connection lost.

57. By Renato Araujo Oliveira Filho

Fixed crash when sync error.

58. By Renato Araujo Oliveira Filho

Avoid sync accoun twice.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected?
NO

Is your branch in sync with latest trunk?
YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES

Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES

If you changed the UI, was the change specified/approved by design?
NO UI CHANGE.

If you changed UI labels, did you update the pot file?
Will be updated in a new MR.

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
YES

59. By Renato Araujo Oliveira Filho

Removed some debug messages.

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

There's a bit of indentation that's out of line (marked with a diff comment), other than that this looks good

review: Needs Fixing
60. By Renato Araujo Oliveira Filho

Identation fixed.

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches