Ubuntu Calendar App

Merge lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1439049 into lp://qastaging/ubuntu-calendar-app

  1. fix-1439049
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Arthur Mello
Approved revision: 787
Merged at revision: 795
Proposed branch: lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1439049
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 269 lines (+92/-52)
1 file modified
calendar.qml (+92/-52)
To merge this branch: bzr merge lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1439049
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
Nekhelesh Ramananthan Approve
Review via email: mp+289198@code.qastaging.launchpad.net

Commit message

Accept 'calendar://*' url as argument on app startup.

This is necessary because url-dispatcher calls the app with uri as an argument if the app is not opened yet.

Description of the change

you need silo 049 to test this:

https://requests.ci-train.ubuntu.com/#/ticket/1123

To post a comment you must log in.
lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1439049 updated
783. By Renato Araujo Oliveira Filho

Trunk merged.

784. By Renato Araujo Oliveira Filho

Accept 'startdate' in the uri handler.

785. By Renato Araujo Oliveira Filho

Trunk merged.

786. By Renato Araujo Oliveira Filho

Handle 'startTime' arg on uri.

Make sure that the app opens on day view with the 'startTime' visible when app is called from uri handler.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

On testing on the device, I found that clicking the event in the indicator opens the calendar app in the Day View (nice!) rather than the month/year/week view. It also nicely positions the hours close to the event. However it does not show the event details page which is critical to fixing this bug.

review: Needs Fixing
Revision history for this message
Arthur Mello (artmello) wrote :

Added some diff comments

review: Needs Fixing
lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1439049 updated
787. By Renato Araujo Oliveira Filho

Removed debug message.
Fixed function name typo.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> On testing on the device, I found that clicking the event in the indicator
> opens the calendar app in the Day View (nice!) rather than the month/year/week
> view. It also nicely positions the hours close to the event. However it does
> not show the event details page which is critical to fixing this bug.

yes we know that, unfortunately we do not have a API necessary to do this right now. (There is no way to fetch for a specific recurrence). As short term solution we will open the day view page in the event time.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> Added some diff comments
fixed.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> > On testing on the device, I found that clicking the event in the indicator
> > opens the calendar app in the Day View (nice!) rather than the
> month/year/week
> > view. It also nicely positions the hours close to the event. However it does
> > not show the event details page which is critical to fixing this bug.
>
> yes we know that, unfortunately we do not have a API necessary to do this
> right now. (There is no way to fetch for a specific recurrence). As short term
> solution we will open the day view page in the event time.

Based on that reasoning, the MP lgtm.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> > On testing on the device, I found that clicking the event in the indicator
> > opens the calendar app in the Day View (nice!) rather than the
> month/year/week
> > view. It also nicely positions the hours close to the event. However it does
> > not show the event details page which is critical to fixing this bug.
>
> yes we know that, unfortunately we do not have a API necessary to do this
> right now. (There is no way to fetch for a specific recurrence). As short term
> solution we will open the day view page in the event time.

Based on that reasoning, the MP lgtm.

Revision history for this message
Nekhelesh Ramananthan (nik90) :
review: Approve
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: