Ubuntu Calendar App

Merge lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1563742 into lp://qastaging/ubuntu-calendar-app

  1. fix-1563742
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Arthur Mello
Approved revision: 818
Merged at revision: 817
Proposed branch: lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1563742
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 103 lines (+66/-1)
3 files modified
calendar_canvas.js (+7/-0)
click/calendar.apparmor (+3/-0)
tests/unittests/tst_calendar_canvas.qml (+56/-1)
To merge this branch: bzr merge lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1563742
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+290901@code.qastaging.launchpad.net

Commit message

Fixed event drawing during the DST change.

Added /etc/writable/timezone as read path on apparmor file.
This is necessary by qtorganizer5-eds to retrieve device timezone.

Description of the change

OBS: You need silo 39 to test it
https://requests.ci-train.ubuntu.com/#/ticket/1213

How to test:

1 - Change your device tz to Europe/Paris
2 - Create a event at 7AM until 8AM before 27th March that repeats every day

Expected result:
Check if the event appears on the same time (7AM-8AM) on 26, 27, 28 of March and all other days

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:814
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/819/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/842/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/819/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1563742 updated
815. By Renato Araujo Oliveira Filho

Fix event drawing on DST change.

816. By Renato Araujo Oliveira Filho

Fixed apparmor invalid syntax.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:816
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/820/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/843/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/820/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1563742 updated
817. By Renato Araujo Oliveira Filho

Added tests for events in multiple days.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:817
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/822/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/847/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/822/rebuild

review: Approve (continuous-integration)
lp://qastaging/~renatofilho/ubuntu-calendar-app/fix-1563742 updated
818. By Renato Araujo Oliveira Filho

Remove empty line.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:818
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/823/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/848/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/823/rebuild

review: Approve (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: