Ubuntu Calendar App

Merge lp://qastaging/~renatofilho/ubuntu-calendar-app/majster-new-event-page into lp://qastaging/ubuntu-calendar-app

  1. majster-new-event-page
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Needs review
Proposed branch: lp://qastaging/~renatofilho/ubuntu-calendar-app/majster-new-event-page
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 1246 lines (+615/-452)
5 files modified
ContactChoicePopup.qml (+227/-107)
KeyboardRectangle.qml (+1/-10)
NewEvent.qml (+294/-273)
NewEventTimePicker.qml (+90/-59)
po/com.ubuntu.calendar.pot (+3/-3)
To merge this branch: bzr merge lp://qastaging/~renatofilho/ubuntu-calendar-app/majster-new-event-page
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Jenkins Bot continuous-integration Approve
Renato Araujo Oliveira Filho Pending
Review via email: mp+294499@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2016-04-11.

Commit message

this is very first proposal for new Event Page, adding new guest is currently to be work on... but first implementation is done.

Description of the change

this is very first proposal for new Event Page, adding new guest is currently to be work on... but first implementation is done.

To post a comment you must log in.
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote : Posted in a previous version of this proposal

Good work. Some small inline comments.

review: Needs Fixing
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote : Posted in a previous version of this proposal

Thanks for the work. I will create a new branch based on this one to fix some small problems.

lp://qastaging/~renatofilho/ubuntu-calendar-app/majster-new-event-page updated
823. By Renato Araujo Oliveira Filho

Trunk merged.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:823
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/majster-new-event-page/+merge/294499/+edit-commit-message

https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/846/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/893/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/846/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://qastaging/~renatofilho/ubuntu-calendar-app/majster-new-event-page updated
824. By Renato Araujo Oliveira Filho

Fixed header license format.

825. By Renato Araujo Oliveira Filho

Remove empty lines.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:825
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/majster-new-event-page/+merge/294499/+edit-commit-message

https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/847/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/894/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/847/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://qastaging/~renatofilho/ubuntu-calendar-app/majster-new-event-page updated
826. By Renato Araujo Oliveira Filho

Update new event header and margins.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:826
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/848/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/895/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/848/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:826
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-calendar-app-ci/3/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/743/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/743
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/690
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/690
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/690
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/682/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/682/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/682/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/682/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/682/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/682/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/682/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/682/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/682/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-calendar-app-ci/3/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

826. By Renato Araujo Oliveira Filho

Update new event header and margins.

825. By Renato Araujo Oliveira Filho

Remove empty lines.

824. By Renato Araujo Oliveira Filho

Fixed header license format.

823. By Renato Araujo Oliveira Filho

Trunk merged.

822. By Renato Araujo Oliveira Filho

Removed commented code.
Fixed code style.

821. By Szymon Waliczek

First implementation of new designs for New Event page.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: