Ubuntu Autopilot Tests

Merge lp://qastaging/~rhuddie/ubuntu-autopilot-tests/add-contact-with-photo into lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests

add-contact-with-photo
Merge into ubuntu-experience-tests

Proposed by Richard Huddie on 2014-06-25

Status:

Needs review

Proposed branch:

lp://qastaging/~rhuddie/ubuntu-autopilot-tests/add-contact-with-photo

Merge into:

lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests

Diff against target:

168 lines (+136/-1)

3 files modified

debian/control (+2/-0)
ubuntu_experience_tests/helpers.py (+1/-1)
ubuntu_experience_tests/tests/contenthub/test_address_book_integration_with_content_hub.py (+133/-0)

To merge this branch:

bzr merge lp://qastaging/~rhuddie/ubuntu-autopilot-tests/add-contact-with-photo

Undecided

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-07-09
Leo Arias (community)		2014-06-25	Needs Fixing on 2014-07-01
Brendan Donegan (community)		2014-06-25	Approve on 2014-07-01
Ubuntu Testcase Admins		2014-06-25	Pending
Review via email: mp+224407@code.qastaging.launchpad.net

Description of the change

A new UX test to create a new contact and add a photo from the gallery.

lp://qastaging/~rhuddie/ubuntu-autopilot-tests/add-contact-with-photo updated on 2014-06-25

31. By Richard Huddie on 2014-06-25: revert previous control file changes and add address-book-app-autopilot and gallery-app-autopilot dependencies
32. By Richard Huddie on 2014-06-25: remove globals used for dbus service, no longer needed

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2014-07-01:

Looks good to me +1

review: Approve

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-01:

From pep 257 for One-line Docstrings, "The closing quotes are on the same line as the opening quotes. This looks better for one-liners."

For Multi-line Docstrings, they need "a summary line just like a one-line docstring, followed by a blank line, followed by a more elaborate description."

Really nice work, thanks Richard. Please don't hate me for sending you to work with the gallery app again.

review: Needs Fixing

lp://qastaging/~rhuddie/ubuntu-autopilot-tests/add-contact-with-photo updated on 2014-07-08

33. By Richard Huddie on 2014-07-02: Fix review comments, TODO comments added where new helper methods are required
34. By Richard Huddie on 2014-07-08: use photos page object from gallery-app helpers
35. By Richard Huddie on 2014-07-08: Use press_photo_icon() helper method from contact editor
36. By Richard Huddie on 2014-07-08: use picker screen select_photo() method
37. By Richard Huddie on 2014-07-08: use contact list page get_contact_avatar_file_path()
38. By Richard Huddie on 2014-07-08: tidy up

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-09:

FAILED: Continuous integration, rev:38
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~rhuddie/ubuntu-autopilot-tests/add-contact-with-photo/+merge/224407/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/20/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1761/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/20/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/20/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/20/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2821/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/20/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

38. By Richard Huddie on 2014-07-08: tidy up
37. By Richard Huddie on 2014-07-08: use contact list page get_contact_avatar_file_path()
36. By Richard Huddie on 2014-07-08: use picker screen select_photo() method
35. By Richard Huddie on 2014-07-08: Use press_photo_icon() helper method from contact editor
34. By Richard Huddie on 2014-07-08: use photos page object from gallery-app helpers
33. By Richard Huddie on 2014-07-02: Fix review comments, TODO comments added where new helper methods are required
32. By Richard Huddie on 2014-06-25: remove globals used for dbus service, no longer needed
31. By Richard Huddie on 2014-06-25: revert previous control file changes and add address-book-app-autopilot and gallery-app-autopilot dependencies
30. By Richard Huddie on 2014-06-24: add additional thumbnail url checking
29. By Richard Huddie on 2014-06-23: use contacts dbus service from helper