configglue

Merge lp://qastaging/~ricardokirkner/configglue/better-hash into lp://qastaging/configglue

better-hash
Merge into trunk

Proposed by Ricardo Kirkner on 2014-03-19

Status:	Merged
Approved by:	Ricardo Kirkner on 2014-03-23
Approved revision:	113
Merged at revision:	113
Proposed branch:	lp://qastaging/~ricardokirkner/configglue/better-hash
Merge into:	lp://qastaging/configglue
Diff against target:	183 lines (+71/-7) 2 files modified configglue/schema.py (+20/-7) configglue/tests/test_schema.py (+51/-0)
To merge this branch:	bzr merge lp://qastaging/~ricardokirkner/configglue/better-hash
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ricardo Kirkner			Approve on 2014-03-23
tenuki (community)			Approve on 2014-03-23
Review via email: mp+211843@code.qastaging.launchpad.net

Commit message

use stricter hashing functions to avoid potential pitfall

Revision history for this message

tenuki (tenuki) wrote on 2014-03-23:

seems good to me!

review: Approve

Revision history for this message

Ubuntu One Auto Pilot (otto-pilot) wrote on 2014-03-23:

Voting does not meet specified criteria. Required: Approve >= 1, Disapprove == 0, Needs Fixing == 0, Needs Information == 0, Resubmit == 0, Pending == 0. Got: 1 Pending.

Revision history for this message

Ricardo Kirkner (ricardokirkner) wrote on 2014-03-23:

Rubber stamping

review: Approve