MAAS

Merge lp://qastaging/~ricgard/maas/bug-1681389 into lp://qastaging/~maas-committers/maas/trunk

  1. bug-1681389
  2. Merge into trunk
Proposed by Richard McCartney
Status: Merged
Approved by: Richard McCartney
Approved revision: no longer in the source branch.
Merged at revision: 5957
Proposed branch: lp://qastaging/~ricgard/maas/bug-1681389
Merge into: lp://qastaging/~maas-committers/maas/trunk
Diff against target: 34 lines (+2/-6)
3 files modified
src/maasserver/static/css/build.css (+1/-1)
src/maasserver/static/partials/nodes-list.html (+1/-1)
src/maasserver/static/scss/_pages.scratch.scss (+0/-4)
To merge this branch: bzr merge lp://qastaging/~ricgard/maas/bug-1681389
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Richard McCartney (community) Needs Resubmitting
Review via email: mp+322301@code.qastaging.launchpad.net

Commit message

Resolving issue for form alignment on add zone, subnet, vlan and commissioning on nodes.

Description of the change

Resolves alignment issue for adding DNS, Zones and subnets on the node and networking listing page.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

The bug you reference is for the DNS page, but this is the nodes listing page?

review: Needs Fixing
Revision history for this message
Richard McCartney (ricgard) wrote :

> The bug you reference is for the DNS page, but this is the nodes listing page?

Correct, I should update the bug it should also reference the node listing page as well.

review: Needs Resubmitting
Revision history for this message
Blake Rouse (blake-rouse) wrote :

I am still confused on how this fixes all of them? Also you still have form--inline on the div?

review: Needs Information
Revision history for this message
Richard McCartney (ricgard) wrote :

> I am still confused on how this fixes all of them? Also you still have form--
> inline on the div?

So form--inline is the correct class as this effects all the children for that class. The issue was in scratch.scss I added display inline block, this set that form container to not be full width thus forcing all elements to be close to each other.

The only form where this this isn't required is where I used the u-display--inline-block utility class to keep the design true while not compromising the layout.

review: Needs Resubmitting
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Ah okay, that makes more since.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.