Merge lp://qastaging/~ricgard/maas/vlan-amendments into lp://qastaging/~maas-committers/maas/trunk

Proposed by Richard McCartney
Status: Merged
Approved by: Mike Pontillo
Approved revision: no longer in the source branch.
Merged at revision: 4743
Proposed branch: lp://qastaging/~ricgard/maas/vlan-amendments
Merge into: lp://qastaging/~maas-committers/maas/trunk
Diff against target: 304 lines (+93/-81)
6 files modified
src/maasserver/static/css/maas-styles.css (+1/-1)
src/maasserver/static/partials/subnet-details.html (+2/-2)
src/maasserver/static/partials/vlan-details.html (+78/-76)
src/maasserver/static/scss/maas/components/_forms.scss (+8/-2)
src/maasserver/static/scss/maas/components/_lists.scss (+1/-0)
src/maasserver/static/scss/maas/components/_tables.scss (+3/-0)
To merge this branch: bzr merge lp://qastaging/~ricgard/maas/vlan-amendments
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
Review via email: mp+288294@code.qastaging.launchpad.net

Commit message

Resolves layout issues for VLAN details; action dropdown, button overlapping and table scaling.

Description of the change

Amenends the layout issues for VLAN details page also fixes subnet titles.

- Resolves actions dropdown layout.
- Button overlapping on smaller screens
- Table content now wrapping on smaller screens
- IPv6 inputs at a set size and max character amount

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Thanks. I still see some issues with the "Provide DHCP" text sometimes taking up two lines and going outside the boundary of the drop-down.

But I'm going to land this anyway since it's a major improvement.

review: Approve
Revision history for this message
Mike Pontillo (mpontillo) wrote :

For the record, I tested this with the node details page (enlisted and commissioned a node) to ensure these changes did not affect other areas of the product.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.