Merge lp://qastaging/~ricgard/maas/vs-repeat-ui-improvement into lp://qastaging/~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Mike Pontillo |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6088 |
Proposed branch: | lp://qastaging/~ricgard/maas/vs-repeat-ui-improvement |
Merge into: | lp://qastaging/~maas-committers/maas/trunk |
Diff against target: |
771 lines (+630/-10) 10 files modified
src/maasserver/static/js/angular/3rdparty/vs-repeat.js (+608/-0) src/maasserver/static/js/angular/maas.js (+2/-1) src/maasserver/static/partials/dashboard.html (+3/-1) src/maasserver/static/partials/machines-table.html (+1/-1) src/maasserver/static/partials/networks-list.html (+2/-2) src/maasserver/static/partials/node-events.html (+1/-1) src/maasserver/static/partials/nodes-list.html (+3/-3) src/maasserver/static/partials/pods-list.html (+1/-1) src/maasserver/templates/maasserver/js-conf.html (+3/-0) src/maasserver/views/combo.py (+6/-0) |
To merge this branch: | bzr merge lp://qastaging/~ricgard/maas/vs-repeat-ui-improvement |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Blake Rouse (community) | Approve | ||
Review via email:
|
Commit message
Created vertical scrolling repeat to improve the loading times of heavy table content pages such as device discovery
Description of the change
Work done
=======
- Added the vs-repeat angular module to MAAS. Module details and code can be found here https:/
- Applied the vs-repeat directive to the following pages:
Device discovery, Node listing, Device listing, Controller listing, Pod listing, Subnet listing, Node events page
How to test
=======
- Pull down the branch and run 'make' then 'make sampledata'
- Go to http://
- View the device discovery page and attempt to rapidly scroll the page. The directive should pull in the table row content and improve the loading time on the page.
- Test in a similar way on other pages such as node events
This is awesome! Thanks for doing it.